push new features out to dev.buttonweavers.com

cgolubi1 commented 10 years ago

As features are merged into the main codebase, redeploy dev.buttonweavers.com with those changes.

Generic procedures for use in deployments:

Use a checked-out copy of buttonmen-master to find a sort order for database updates:

cd deploy/database/updates/
UPDATES="<space-separated list of DB updates>"
git log --reverse --first-parent --oneline $UPDATES
UPDATES="<space-separated list of DB updates, now in the order reported by that output>"

Database update plan:

# in the correct git working directory
git pull origin dev
cd deploy/vagrant
vagrant provision

# on the sandbox or dev VM
UPDATES="<space-separated ordered list of DB updates, as determined above>"

mysqldump -u root buttonmen | sed -e 's/),(/),\n(/g' > ~/buttonmen_db.$(timefmt).sql
cd /buttonmen/deploy/database/updates
for update in $UPDATES; do
  echo "APPLYING: $update"
  cat $update | mysql -u root buttonmen
done

mysqldump -u root buttonmen | sed -e 's/),(/),\n(/g' > ~/buttonmen_db.$(timefmt).sql

How to diff database dumps:

diff --side-by-side --width=234 --left-column buttonmen_db.* | less

Within less, search for lines that don't end with ( to skip past common lines: /!\($

cgolubi1 commented 10 years ago

I redeployed the alpha site just now, with the fixes for:

219
201
200
206
212

cgolubi1 commented 10 years ago

I redeployed the site with fixes for:

211

cgolubi1 commented 10 years ago

I redeployed the site with fixes for:

272

cgolubi1 commented 10 years ago

I redeployed the site with fixes for:

97

cgolubi1 commented 10 years ago

I redeployed the site with fixes for:

backend of #87 and #88: WARNING: because we have the backend of focus and chance, but not the UI, the "new game" dialogue will now tell you that you can play buttons with focus and chance dice. However, unless you like playing buttonmen by sending JSON requests to our as-yet-undocumented API, you can't actually do so yet because the UI doesn't support focus and chance, and those games will fail with "Can't figure out what action to take next". If you file tickets about this, we will close them as duplicates. :>)
285: discrepancy between game state in the overview page and the game page, affecting game 36
possibly #218: if a player turns on autopass while a game is waiting for them to pass, the game gets into a bad state

cgolubi1 commented 10 years ago

Okay, so, fie on me for not looking at the diff stats, and on James for not mentioning what was in his pull request --- this is a major change to existing DB tables. I had no idea this was involved in this commit, so if i rebuild the site and it doesn't work, there's going to be trouble that i can't debug for 8 hours until James is around again. So i'm going to roll alpha back to before this change:

cd ~/src/git/buttonmen-dev/buttonmen-master
git reset --hard c1b3683009afb190f1370624e3e564af5aabc225

then do the usual AWS reload. Did that, and now the site is back online and the overview page is usable again.

Later today, when James is online, i'll reapply this commit, and the other one which needs a DB refresh while i'm at it, and do a full site clobber. There's just no point doing it now, because if any problems arise, i can't fix them.

cgolubi1 commented 10 years ago

In case anyone is following along from home and is confused by the play-by-play, here's the current state:

The pull request with the focus and chance die backend logic is now live. That means that the UI will (incorrectly) tell you that you can play chance and focus buttons now, and you should ignore it and not play them.
Pull request #289 is not live yet.
Later today (Wednesday), we will probably make pull request #289 live, clobbering the database

cgolubi1 commented 10 years ago

Okay, i rebuilt the site, bringing in fixes for:

285
171
254

That's rebuilt, meaning the database got clobbered. Please recreate your username and play some more.

cgolubi1 commented 10 years ago

I redeployed this morning, to fix:

292: a backend issue testers don't care about
290: the berserk die null value bug - test this

cgolubi1 commented 10 years ago

I redeployed this morning, doing a database reload in the process, so please recreate your accounts. There are three fixes, all of (some) interest to testers:

Pull #301, issue #232: add unit testing of the javascript. Y'all should be able to browse to http://alpha.buttonweavers.com/test-ui/ and run the JS test suite on your browser/OS. Any tests fail for you? I'd be interested in knowing that.
Pull #299, issue #259: the konstant skill is now implemented.
Pull #298, partial fix for issue #280: first overhaul of the list of buttons, including some new-to-the-site buttons

On that last one in particular, if any of the button recipes don't match what we had on the old site in important ways, that'd be good to know, and other kibbitzing is welcome as well --- please comment on ticket #280.

cgolubi1 commented 10 years ago

I updated the site this morning (not a rebuild, so you still have your accounts) with a million tiny fixes:

Pull #307 for bug #291: fix a UI bug in displaying twin die side counts
Pull #310 for bug #215: display expected ranges when setting swing dice
Pull #308 for bugs #173 and #204: display button name and WLT on swing die selection page
Pull #314 for bug #81: add a small navigation bar
Pull #315 for bug #150: don't let people try to start games against themselves in the UI
Pull #312 for bug #238: show the next game action in the header of each page on game.html
Pull #317 for bug #100: display dice each player has captured during a round
Pull #320 for bug #319: internal error when selecting buttons with no swing dice

Quick reminder: focus and chance dice still show as playable in the UI, but still aren't yet. I'm working on it.

Anyway, have at it. Many of those bugs were filed by alpha testers, so take a look and see if you're happier now. If not, comment on the existing tickets, and we'll figure out whether to reopen them or start new tickets.

cgolubi1 commented 10 years ago

I rebuilt the site this morning with a small number of relatively large fixes. Please recreate your accounts.

Pulls #325 and #327 to implement the frontend and fix the backend of focus and chance dice (#87 and #88). Obviously, these need lots of testing. Three things to look out for in particular:
- Focus dice don't get dizzy after turndown. This is a known bug (#328), just a heads-up that you don't need to file it.
- The message after you focus/chance turndown always tells you that it succeeded (unless it failed because you did something wrong). It should tell you whether or not you got initiative. Also a known bug (#329).
- Something is pretty weird about chance dice still, but we haven't characterized it enough to file it. Please do!
Pull #326 fixes #237, initial implementation of in-game chat. Since we keep reloading the database, please treat chat as ephemeral --- don't start any story tournaments.

cgolubi1 commented 10 years ago

I updated again just now (no DB reload) to bring in pull #331, which may be a fix for the chance logic. Please do bang on the chance behavior (as well as the focus behavior) and complain about anything that seems wrong.

cgolubi1 commented 10 years ago

I updated today to bring in:

Pull #334 fixing #329 - better message to player after react_to_initiative

cgolubi1 commented 10 years ago

I rebuilt the site (including a new database, so recreate your accounts) this morning to bring in these fixes:

Pulls #368, #380, #382 fixing #229, #280, #281, #379, #381: add all buttons from old site (including fanatics) and fix some merge problems
Pulls #357, #373 fixing #101: user preferences UI that allows you to set autopass for yourself
Pull #378 fixing #374: round number is now correct at end of game
Pull #375 fixing #297: completed games should now show up in the overview again
Pull #351 fixing #346: focus should now work correctly in the case in which one player gains initiative using focus dice and the other player chooses not to respond
Pull #377: backend code for surrendering (no front-end yet)

cgolubi1 commented 10 years ago

I pushed out new code to the site (no database rebuild), including:

Pull #387 fixing #383: Wildcard should be correctly listed as "unimplemented" again
Pull #391 fixing #390: QUnit tests should pass on IE

cgolubi1 commented 10 years ago

I'm pushing out new code to the site now (no database rebuild), including:

a very small number of user-visible things:
- Pull #402,#415 fixing #413 and addressing the backend of #328: focus dice are now dizzy (but we still have to fix the frontend so that you can't try to attack using them --- right now, you'll get a hopefully-friendly error if you do)
and also a bunch of things users shouldn't see or care much about:
- Pull #408 fixing #406: a refactor of the button table which should be transparent
- Pulls #401,#403,#412 fixing #143,#358: cleanup of data reported by the public API, doesn't currently change anything in the UI
- Pull #399 fixing #300: fix an inconsistency in the unit test database
- Pull #411 fixing #410: test database should use a different mysql user

cgolubi1 commented 10 years ago

Hmm, so, when puppet ran on boot, i got:

err: /Stage[main]/Buttonmen::Server/Exec[buttonmen_create_databases]/returns: change from notrun to 0 failed: /usr/local/bin/create_buttonmen_databases returned 1 instead of one of [0] at /tmp/vagrant-puppet/modules-0/buttonmen/manifests/init.pp:54

Frankly, i'm filing this under "i'm not sure why this ever worked", because of the bug in #410. If it persists after the next site rebuild, i'll investigate then. (Sigh, okay, let me be a little less terse --- the issue with #410 is that using "root" as the user for the test database, changes the overall password which "root" uses to access mysql at all. Since under Ubuntu "root" is the mysql admin user which creates/drops/grants to databases during create_buttonmen_databases, this means that create_buttonmen_databases will work either before or after the first time buttonmen_test is initialized, but not both. Ah hah! And i'm rewarded for spelling it out because now it's obvious what happened --- puppet only bothers to run create_buttonmen_databases if triggered to do so by a change in that script itself (or maybe some other conditions). So normally it doesn't fail on boot, but only because normally it doesn't run on boot. Okay, good.)

cgolubi1 commented 10 years ago

I rolled out new code to the site, including:

Pull #420 fixing #418: it should now once again be possible to view completed games
Pulls #421,#422,#423 addressing #417: many PHP coding style fixes to address Jenkins complaints - these should be noops, but try a bunch of things that used to work to make sure
Pull #427: placeholder soldiers images (not used)
Pulls #416,#425 addressing #376,#424: Jenkins configuration, doesn't affect alpha

cgolubi1 commented 10 years ago

I'm rolling out new code to the site now, including:

Pull #431 fixing #429: dizzy focus dice backend fix --- now all of your focus dice should remain dizzy even if you don't turn them down all at the same time
Pull #428: backend for descriptions of dice (no frontend yet)

cgolubi1 commented 10 years ago

I'm pushing code out to alpha with these fixes:

Pull #432: validate "decline" action when responding to initiative
Pull #435 addressing #417: code cleanup to make PHPMD happier --- shouldn't break anything, but let us know if it does
Pull #434 addressing #433: JS fix to support old firefox versions
Pull #436 fixing #316: fix race condition when both players need to set swing dice
Pull #437 addressing #105: jenkins test suite should run jshint (doesn't actually affect alpha, just listing it for completeness)

cgolubi1 commented 10 years ago

I tried pushing out code nondisruptively to the site using "vagrant provision". Changes pushed:

Pulls #437, #448, #449 fixing #376, #419: automating unit tests and jshint checks against javascript, and a bunch of code cleanup which should be noops to make jshint happy
Pull #446 fixing #92: implement morphing
Pull #447 fixing #274: implement doppleganger

Give that a try.

cgolubi1 commented 10 years ago

Pushed code out nondisruptively, including:

Pull #454 fixing #430, #405, #328: make it more obvious when you can't click on dice by putting them on an ugly grey background which i would replace with a round background if only someone gave me a circle with a light grey background hint hint

cgolubi1 commented 10 years ago

Updated the site with these fixes:

Pull #457: make the "inactive die" background round
Pull #455 fixing #342: if you choose "no action" but select some dice to turn down/reroll, it should be an error

cgolubi1 commented 10 years ago

Updated the site with this fix:

Pull #459 fixing #451: when you reroll a morphing die, action log should now correctly show that the recipe has changed, and what the new recipe is

cgolubi1 commented 10 years ago

Updated the site with this fix:

Pull #466 fixing #460: berserk poison dice should now be able to make berserk attacks

cgolubi1 commented 10 years ago

Updated the site with these fixes (n.b. some of these fixes were pushed out yesterday, but i lost my tiny mind and failed to actually submit my ticket update about it, sigh):

Functionality:
- Pull #470 fixing #145: allow users to see games they're not participating in
- Pull #469 fixing #461: give the user a cleaner message when a PHP fatal error occurs
- Pull #473 fixing #456: better message when user gains initiative using chance dice
- Pull #472 fixing #453: when doppelganging a null die, don't become null
- Pull #476 fixing #353: retain chat box contents on invalid attack
- Pull #477 fixing #208: retain attempted attack parameters on invalid attack
- Pull #480 fixing #341: retain focus parameters when dice not set low enough, and improve message in this case
- Pull #481 fixing #335: don't double-encode chat text
Refactors:
- Pulls #471,#474 fixing #468: refactor how the UI code invokes API POST to catch more errors
- Pull #475 fixing (i hope i hope) #441: error causing sporadic QUnit failures
- Pull #483 fixing #479: extraneous debugging code in unit test output

cgolubi1 commented 10 years ago

While i'm at it, also went ahead and updated:

Pull #484 fixing #478: round number should agree with W/L/T now

cgolubi1 commented 10 years ago

Updated the site with these fixes:

Pull #488 fixing #340: dizzy dice in focus reduction screen, and first mouseover text to explain why dizzy dice are grey
Pull #491 fixing #83: stealth dice

cgolubi1 commented 10 years ago

BTW, just so others don't have to do the math too: now that we have stealth dice, i believe these buttons are newly-playable:

Howling Wolf    d(4) (8) (12) (20) d(20)
White Tiger     (6) d(6) (10) (12) d(12)
eon             t(4) n(6) d(8) B(16) B(X)
Grym            (4) t(6) d(10) z(12) (X,X)
Kaeriol         (4) (6) d(6) s(10) B(X)
llippen5        d(4) d(6) d(8) d(10) d(12) d(20)
schwa           f(V) t(W) d(X) v(Y) B(Z)

cgolubi1 commented 10 years ago

Updated the site with these fixes:

Pull #497 fixing #77: show text descriptions of dice as a mouseover during choose swing, react to initiative, and attack
Pull #496 fixing #392: all submit buttons should be disabled before POST so they can't be clicked repeatedly
Pull #495 fixing #404: during attack, submit button should say "Beat People UP!"
Pull #494 fixing #490: all browsers should report e.g. "Power Attack" rather than "Power" in the attack type selection
Pull #485 fixing #330: API change, shouldn't be visible --- report game state as a string rather than a number

cgolubi1 commented 10 years ago

Updated the site with these fixes:

Things you can see:
- Pull #517: relatively major refactor of game battle UI, to make the UI less vertical, resolve some other issues, and link to buttonmen art. Note: we only have art for soldiers, so play games with soldiers if you want to see art.
- Pull #515 fixing #120: after you create a game (successfully or unsuccessfully), retain the game settings on the page in case you want to create another similar game
Things you shouldn't be able to see (yet, in some cases):
- Pull #486 fixing #445,#393,#452,#407,#444: fix typoes and minor errors in button database table (but this is not live yet, because we need a site reload to do it)
- Pull #516 fixing #228: move API endpoint from /api/responder.php to /api/responder (technically, you can see this if you've been interacting with our API directly, which is probably no one, but you never know)
- Pull #501 fixing #500: jenkins test timeout issue
- Pull #503 fixing #502: jenkins test filesystem space issue
- Pull #522 fixing #521: add attribution for buttonmen art

cgolubi1 commented 10 years ago

Updated the site with a couple of small fixes:

Database changes to add more official button sets (pull #525), which you still can't see because i still haven't reloaded the DB
Improve the text for a couple of user creation errors (pull #527)
When choosing swing dice, display the opponent's legal swing die ranges too (pull #529)

cgolubi1 commented 10 years ago

Updated the site, still deferring the database reload:

Pull #538: add a bunch of larger button art, and a default image for buttons that have no art
Pull #537 fixing #400: winning score always appears first in action log

cgolubi1 commented 10 years ago

I reloaded the site, including a full database rebuild (so, for those who have forgotten the drill, you need to recreate your accounts). This includes:

Pulls #525 and #486: various button database changes
Pulls #531 and #542: backends for auxiliary and reserve. Note that these buttons are NOT playable, but think they are. Caveat alpha tester. Avoid aux and reserve buttons for now --- we'll tell you when it's safe to try them.
Pull #545: collect and verify user e-mail addresses on account creation
Pull #543: implement Echo/Zero

cgolubi1 commented 10 years ago

I updated the site yesterday (no database reload) with these fixes, then forgot to actually submit this comment:

Pull #568: use cookies more actively to generate session keys. This does ''not'' address security concerns about session use, but i hope will address the problem of people being logged out every 20 minutes: let us know how it works out.
Pull #565: modify the From: and Reply-To: of e-mails the site sends to be legitimate addresses. (This will partly, but not fully, address the issue of new user e-mails getting tagged as spam.)
Pull #566: make the UI less confusing when a user logs in while staying on the verify.html page
Pull #567: create game button should say "Create Game!" rather than "Start Game!"

cgolubi1 commented 10 years ago

Reloading the site now with:

Pull #574: first cut at Jota's UI design
Pull #573: mail from should masquerade as buttonweavers.com, will hopefully stop us from being filed as spam so much
Pull #569: send "sides" calculation to frontend

cgolubi1 commented 10 years ago

Reloading the site now with:

Pull #578: should fix the Echo issues
Pull #580: UI for auxiliary dice
Pull #582: UI for reserve dice
Pull #590: action/chat logs should use the same colors as the battle mat

blackshadowshade commented 10 years ago

FYI, you'll probably need to hit reload to get the site using the new auxiliary and reserve pages.

cgolubi1 commented 10 years ago

Reloading the site now with:

Pull #593: fix bug affecting auxiliary swing dice
Pull #594: fix leak of swing setting information via die descriptions

cgolubi1 commented 10 years ago

Reloading the site now with:

Pull #595: reenable Bruno, Sailor Moon, and Tenchi Muyo! buttons with unimplemented button specials
Pull #601: the active player should see dice with white backgrounds
Pull #602: nowrap in the dice row listing

cgolubi1 commented 10 years ago

Reloading the site now with:

Pull #606: should allow the rest of the sailor moon buttons to be enabled on the site
Pull #607: more button images
Pull #608: refactor activity log and add log entries for many more actions

Once i push the code out, i'll apply the database update that goes with pull #608

cgolubi1 commented 10 years ago

I updated the site quickly just now with:

Pull #611: fix for backwards-compatible treatment of old action logs

cgolubi1 commented 10 years ago

Reloading the site now with:

Pull #612, #618: change the API-reported state of focus dice from disabled to dizzy (should be a noop for UI users)
Pull #613: fixes the round number in the action log at the end of the game
Pull #620: fix broken action log entries for decline focus/aux/reserve cases
Pull #622: more button art!

One database modification: 00605_dizzy_disabled_01.sql

cgolubi1 commented 10 years ago

Updating the site now with:

624, #635: implements surrender UI and fixes the backend
631: report defender reroll values during successful trip attacks
636: background color for the UI describing what action is next
638: fix a button recipe (for EDG)
639: add more horizontal whitespace to battle mat
640: add a config table to the database, and don't report unimplemented buttons on production site_type (e.g. the beta site)
641: don't allow unauthenticated user to access most functions
645: more button art

Database modifications:

00621_edg_recipe_01.sql
00600_config_table_01.sql

cgolubi1 commented 10 years ago

Updating the site with:

651: fixes a state problem introduced by #635

cgolubi1 commented 10 years ago

Updating the site with:

642: lock down apache access to files that shouldn't be user-visible
644: allow a given user to have 3 simultaneous logins instead of 1
632: explicitly nowrap die recipe text to try to solve problems affecting IE

Database update:

00098_multiple_logins_01.sql

cgolubi1 commented 10 years ago

Updating the site with:

658: clean up surrender logic so that action log entries are ordered correctly
656: fix the autoplay bug (we think!)

cgolubi1 commented 10 years ago

Updating the site with:

662: more button images
661: add some front-page help text for logged out users

cgolubi1 commented 10 years ago

Updating the site with:

668: allow users to have slightly more simultaneous auth cookies
669: fix for the swing-after-reserve bug

buttonmen-dev / buttonmen

push new features out to dev.buttonweavers.com #217

219

201

200

206

212

211

272

97

285: discrepancy between game state in the overview page and the game page, affecting game 36

285

171

254

292: a backend issue testers don't care about

290: the berserk die null value bug - test this

624, #635: implements surrender UI and fixes the backend

631: report defender reroll values during successful trip attacks

636: background color for the UI describing what action is next

638: fix a button recipe (for EDG)

639: add more horizontal whitespace to battle mat

640: add a config table to the database, and don't report unimplemented buttons on production site_type (e.g. the beta site)

641: don't allow unauthenticated user to access most functions

645: more button art

651: fixes a state problem introduced by #635

642: lock down apache access to files that shouldn't be user-visible

644: allow a given user to have 3 simultaneous logins instead of 1

632: explicitly nowrap die recipe text to try to solve problems affecting IE

658: clean up surrender logic so that action log entries are ordered correctly

656: fix the autoplay bug (we think!)

662: more button images

661: add some front-page help text for logged out users

668: allow users to have slightly more simultaneous auth cookies

669: fix for the swing-after-reserve bug