search

buttonmen-dev / buttonmen

Buttonmen - an online dice game
Other
16 stars 24 forks source link

UI reports incorrect fire turndown when konstant dice contribute negative amounts #2726

Open blackshadowshade opened 3 years ago

blackshadowshade commented 3 years ago

In #2389, Chaos noticed that the UI doesn't correctly calculate the valid amount of turndown that is required for a complicated fire-assisted attack:

negative_fire_turndown

A proper fix for this would be to have the backend report all possible valid fire turndown amounts. It would also address #1802.

cgolubi1 commented 3 years ago

Here's a corollary bug, with the same fix, but a more serious symptom --- the player does have a valid power attack (because the twin die can be turned down to 1), but the UI doesn't let the player perform it. If they wanted to do that attack, they'd need to use the API:

ui_bug_prevents_legal_attack

cgolubi1 commented 1 year ago

Right now this issue doesn't impact the production site, because we don't currently allow Konstant and Fire on the same button. See #2877 for how long it took us to get on the same page about this.