Closed irilyth closed 1 month ago
There is at least one other place that needs to be changed in the Help documentation.
I was looking at the new wiki today, and it seems like the migration is incomplete? The Fanatics are certainly incomplete.
Can anyone weigh in on whether we still need the links from the old wikis?
Hm, I did a find | grep
for buttonweavers.fandom.com
and didn't come up with anything else. Something else in this Help.js file? Or some other place?
Yup, the Help.js file is what you're looking for.
I guess I didn't phrase that correctly. I was under the impression that both wikis had been merged into one. Is that not correct?
I was looking at the new wiki today, and it seems like the migration is incomplete? The Fanatics are certainly incomplete.
Do you have an example? I did a quick search for "fanatics" on the old wiki, and didn't see an obvious page of Fanatics or anything.
Can anyone weigh in on whether we still need the links from the old wikis?
The only place those links show up is in forum code, right? I'm pretty willing to assert that no one's created a wiki link in any forum post in quite some time; the old wiki is 100% dead as far as I can tell, I don't think anyone's edited any pages there in a year or two (although it's hard to tell, since the recently updated pages list is empty, but that itself is probably a sign).
I guess I didn't phrase that correctly. I was under the impression that both wikis had been merged into one. Is that not correct?
Oh, you mean the buttonmen.fandom.com wiki? I have no idea if it's been merged into buttonmen.wiki, I was never particularly involved with it; but the forum links never pointed there anyway, so it's not really relevant to #2914 or this PR in any case.
As far as I am aware, there were not individual pages for the Fanatics in the old wiki. Of course, there were not individual pages for any buttons in the okd wiki. Yes, the main Fanatics set page still needs editing, but that can be a work 8n progress, and maybe we actually get someother people to help out there. I basically made 98% of the individual button pages myself.
TLDR, I think the migration is basically complete. There is some work left to be done, but that’s just further improvements.
Yup, irilyth, you got my gist now, sorry for my imprecision.
I seem to remember that TheOrgg had collected stories about Fanatics on the old wiki, and I couldn't find those on the new wiki. Is that because they were on the buttonweavers wiki and not the Button Men wiki (or vice versa)?
I seem to remember that TheOrgg had collected stories about Fanatics on the old wiki, and I couldn't find those on the new wiki. Is that because they were on the buttonweavers wiki and not the Button Men wiki (or vice versa)?
Could be; I don't remember the history of buttonmen.fandom.com and how it relates to buttonmen.wiki.
The particular problem I'm trying to solve is that forum links like [wiki=foo]
currently point to buttonweavers.fandom.com, and they should instead point to buttonmen.wiki, which is what #2914 is about. I'm not really interested in taking on a project like "improve the wiki situation in general".
I was just surprised that I still saw two wikis on the help page when I had expected one. If we still have two wikis though, that's fine.
Regarding CircleCI, I can't find the link to its run, although you noted on Discord that it indicates errors. Could you drop a link to the run (if you have it)?
The error is this:
Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed. Cloning git repository
error cloning repository: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
That error seems pretty odd, I can't imagine why CircleCI can't find either git or ssh.
On my most recent passing pull request, my "Checkout code" log looks like:
Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed. Cloning git repository Enumerating objects: 44148, done. Counting objects: 100% (1870/1870), done. Compressing objects: 100% (1024/1024), done. Total 44148 (delta 955), reused 1564 (delta 786), pack-reused 42278 Checking out branch HEAD is now at 95d4fcd Yearly update of copyright year to 2024
Looks like there may be a problem associated with the deploy key, which I see here:
My thought, @irilyth, when you have time, is that you may need to create or associate a deploy key for your account specifically.
See https://circleci.com/docs/github-integration/ and https://stackoverflow.com/questions/74004701/circle-ci-error-cloning-repository-repository-not-found
Those docs don't seem to have step-by-step instructions, and I'm not sure where to put the various parts of this.
At CircleCI, I see
Deploy Key irilyth/buttonmen deploy key PREFERRED SHA256:3k4wxnmqVluLAQS1UMBlS4VxCjt9Py0r18zEYhGyLW0
but when I click on that link, GitHub says "There are no deploy keys for this repository". So perhaps I need to get the public key from CircleCI and add it to GitHub? That SHA256
business is a fingerprint, not the pubkey itself, and I don't see an obvious way to get it.
I tried adding the fingerprint at GitHub, but that didn't work, it says "Key is invalid. You must supply a key in OpenSSH public key format"
There's an "X" button which I suspect might delete the current CircleCI key; perhaps if I do that, it'll let me create a new one, and give me the pubkey at that time? I don't see an obvious way to add a new readonly key without deleting the current one. I can give that a try if no one has any better ideas -- the current one doesn't seem to be doing anything useful anyway, at least not at GitHub.
Aha: I decided to just try it, so I deleted the existing deploy key, and added a new one, and it didn't show me the pubkey, but it automatically added it to GitHub. I wonder where the previous one went; maybe I got a notice about it not having been used in a while and deleted it, or something.
Anyway, back at CircleCI, I told it to re-run the pipeline, and that seems to have worked!
Excellent!
CircleCI passes, as expected. This looks good to me.
I put up a dev site for this at https://2914-wiki-links.irilyth.dev.buttonweavers.com/ui/ --- i think we're still not merging things (i made an exception for the copyright year) until we have a path to deployment, but if someone says it looks good, i'll tag it ready-to-merge.
I've created a wiki link on the forum for UBFC (which was the example given) and that works.
The help links appear to work correctly. I've identified the thing that throws me off every time though: the title of the Buttonweavers wiki is "Buttonmen Wiki". That's not to be fixed in this pull request though.
This is ready to merge and has been checked, so i'm going to tag it that way and tear down the dev site.
Merge freeze is over, so let's merge this.
Fixes #2914.