search

buttonmen-dev / buttonmen

Buttonmen - an online dice game
Other
16 stars 23 forks source link

Implement `cartesian` tool for projects of getting sets of buttons to game counts #2934

Open agathazeren opened 4 months ago

agathazeren commented 4 months ago

It's left as a draft because i need to eliminate the commenting out of the future imports. (probably either setting up virtualenv and using an older version of python or updating the codebase, but maybe it's something else that I have to research.) It also should be updated to use: https://github.com/buttonmen-dev/buttonmen/pull/2912 once that lands

Sample run:

~/code/buttonmen/tools/api-client/python> ./cartesian "Cowboy Bebop"
Ed
---
Faye 3
Jet 1

Ein
---
Faye 3
Jet 2
Spike 2

Faye
---
Spike 3
Vicious 3

Jet
---
Spike 4

Spike
---

Vicious
---
blackshadowshade commented 4 months ago

I reckon this could do with a little bit of commenting so that it's obvious what it does---both for others and for future you. :)

agathazeren commented 4 months ago

I agree. I'm not sure when I will get this sorted, but I'll try to get to it in not too long.

blackshadowshade commented 3 months ago

Just noting that the correct way to be bringing in updates into your branch is to rebase your branch instead of merging our changes. This means that your branch becomes relative to our current code status and that we don't have merge issues.