search

buttonmen-dev / buttonmen

Buttonmen - an online dice game
Other
16 stars 24 forks source link

Fix mechanism for finding the current git commit ID during archived replay testing #2954

Closed cgolubi1 closed 4 months ago

cgolubi1 commented 4 months ago

I think this broke because i was previously checking out my own primary branch and then overlaying the branch under test, and now i'm checking that branch out directly.

Regardless, it's clearly more portable to ask git for the commit ID than to try to figure it out by looking at files in .git. And with this change, replay_loop -a (archive) doesn't blow up.

I tested this on a replay site, and was able to successfully create archive files.

blackshadowshade commented 4 months ago

Happy to give this a go. Merging now.