search

buttonmen-dev / buttonmen

Buttonmen - an online dice game
Other
16 stars 24 forks source link

Fix a grammatical error in some flavor texts #2984

Closed TheOrgg closed 2 months ago

TheOrgg commented 2 months ago

Several flavor texts are missing the comma after their second-to-last list item. Nonce found this and used it as a trivia question.

To quote Nonce:

AnnoDomini, Gluttony, Pride, Pisces, Taurus, Farrell, Lorrie, CynCyn, Maskin, Flaire, Floriano, Queen Serenity, Von Pinn, Connie, Lapis Lazuli, Kaeriol and zaph.

I only counted it for those with a list of three or more items. Most buttons use the Oxford Comma, but usage is inconsistent within most sets.

blackshadowshade commented 2 months ago

I would disagree that this is a grammatical error.

I seem to remember that I've discussed this before and decided not to change it.

Unless people feel strongly about this issue, I'm inclined to mark it as wontfix and close it.

PoshFrosh commented 2 months ago

Personally, I love the Oxford comma, but it has always been used inconsistently and is falling out of style as time moves on. So I'm going to play devil's advocate here and agree with BSS. The New York Times style guide, Canadian style guides, and the majority of British style guides recommends against its use (source, second paragraph: https://en.wikipedia.org/wiki/Serial_comma), so to label it a "grammatical error" might be a bit strong. Even in the first post of this issue, where the buttons are listed, the oxford comma is missing, unless that was a purposeful joke.