search

buttonmen-dev / buttonmen

Buttonmen - an online dice game
Other
16 stars 24 forks source link

Support replay for failed submitTurn entries #2995

Closed cgolubi1 closed 1 month ago

cgolubi1 commented 1 month ago

Sorry for the bother - i was in too much of a hurry to merge #2992 and didn't test it for whether the games it created could be replayed. Rookie mistake, and i even have a flag to replay_loop to support that testing, i was just in a hurry.

Anyway, this PR fixes that one so when submitTurn fails expectedly, PHP-based replay testing correctly expects that failure as well. I've tested it using replay_loop -l, where i've played 1200 novel games, replayed them all, and also replayed 1200 games from the archive, and those all passed.

blackshadowshade commented 1 month ago

This change is to random_ai only.

I see a CircleCI success here: https://app.circleci.com/pipelines/github/cgolubi1/buttonmen/264/workflows/ff54109b-ad05-4968-82b6-25bdc9da8b3a/jobs/532

Accepting this pull request now.