search

buttonmen-dev / buttonmen

Buttonmen - an online dice game
Other
16 stars 24 forks source link

Error during createUser on dev site #703

Closed yawetag closed 10 years ago

yawetag commented 10 years ago

I attempted to register on the dev site and got the following error:

Internal error: got unparseable response from createUser

jimmosk commented 10 years ago

Ditto.

irilyth commented 10 years ago

Do you already have accounts on the dev site? If so, you don't need to register again.

(I was able to log in to the dev site just fine with my existing alpha account.)

If that's the problem the error message could probably be more helpful.

yawetag commented 10 years ago

I do. I was under the impression that all the databases got scrubbed, so thought we'd have to sign up again.

Andrew Senger asenger@gmail.com

On Wed, Mar 12, 2014 at 9:20 AM, irilyth notifications@github.com wrote:

Do you already have accounts on the dev site? If so, you don't need to register again.

(I was able to log in to the dev site just fine with my existing alpha account.)

If that's the problem the error message could probably be more helpful.

Reply to this email directly or view it on GitHubhttps://github.com/buttonmen-dev/buttonmen/issues/703#issuecomment-37413229 .

cgolubi1 commented 10 years ago

The actual issue here is the internal error when you try to create an account and that account already exists. That's probably bitrot from splitting BMInterfaceNewuser from BMInterface --- i'll take a look.

cgolubi1 commented 10 years ago

Blast, i can't reproduce this on vagrant, though i can on dev itself... looking further...

Okay, so the log has:

PHP Notice:  Undefined variable: statement in /var/www/engine/BMInterfaceNewuser.php on line 119, referer: http://dev.buttonweavers.com/ui/create_user.html
PHP Fatal error:  Call to a member function errorInfo() on a non-object in /var/www/engine/BMInterfaceNewuser.php on line 119, referer: http://dev.buttonweavers.com/ui/create_user.html

Ah, good, if i load the database from dev onto my vagrant instance, i can reproduce it there. So something is up with the database state.

This was a deploy error on my part --- when i installed the update containing pull request #691, which i helpfully don't even have a record of doing, i failed to install the database update part. Blech.

Okay, what pulls are missing from my record on #217 --- did i miss any other database updates?

These are the pulls i failed to document:

    Merge pull request #691 from cgolubi1/677_limit_ip
    Merge pull request #688 from cgolubi1/671_front_page_beta_fix
    Merge pull request #686 from cgolubi1/159_zoe_ascii

Pull 686 also has a database update, and it was also not applied. Pull #688 has no database update.

cgolubi1 commented 10 years ago

I fixed this on the live (dev) site and verified that it is not an issue on the main site. We need better procedures in place to keep database updates from getting missed, if we are going to continue to push out 10 database updates a week to two sites.