Certik audit fixes - Githubissues

buttonwood-protocol / button-wrappers

Solidity code for the ButtonToken rebasing wrapper protocol

GNU General Public License v3.0

13 stars 10 forks source link

Certik audit fixes #29

Closed aalavandhan closed 3 years ago

aalavandhan commented 3 years ago

Fixed issues:

BTC-01 | Redundant Import
BTC-03 | Redundant Require
BTC-05 | Bad Function Name
BTC-06 | Missing Approval Event Emission

Issues we'll tolerate:

BTC-02 | Variable Mutability: I dont think solidity allows string variables to be marked immutable. Immutable variables cannot have a non-value type.
BTC-04 | Missing Checks: Invalid erc20 metadata attributes like name and symbol are tolerable.
BTC-07 | Local Variable Explicit Return: Personally prefer explicit return variables over named variables.