Button Token v0 - Githubissues

buttonwood-protocol / button-wrappers

Solidity code for the ButtonToken rebasing wrapper protocol

GNU General Public License v3.0

13 stars 10 forks source link

Button Token v0 #4

Closed aalavandhan closed 3 years ago

aalavandhan commented 3 years ago

Basic rebasing button token wrapper

aalavandhan commented 3 years ago

Nice work - this all looks great and makes sense. It's way nicer to just have the balances float on query instead of explicit rebase like my original idea.

I assume writing tests / hooking the existing Fragments tests into this implementation is future scoped work? I have a few concerns about precision loss that may occur, would like to test and verify

Yea. I'll get to the unit testing in a future PR

marktoda commented 3 years ago

Unrelated question and non-blocking - do you have a gpg key w/ which you can sign commits? Generally good opsec habit I'd like our team to follow