buttonwoodcx / bcx-aurelia-reorderable-repeat

An Aurelia repeater supports drag & drop reordering automatically.
https://buttonwoodcx.github.io/doc-bcx-aurelia-dnd/reorderable-repeat
MIT License
19 stars 5 forks source link

Example result not actual result #18

Closed HeyndrickxKarel closed 4 years ago

HeyndrickxKarel commented 4 years ago

Hi

For an application I'm developing I wanted to use your documented example: "Multiple lists with reorderable-group-for". However, it seems to me that I do not get the same results as in the example.

In the example every reordering action gets logged but when I use the exact same code with the latest version of your package it logs every reordering except for one. It doesn't log the action when you move an item to an empty array. I believe the empty array doesn't trigger the reordering anymore.

I tried this in an application set up like so: image

With the following dependencies: image

3cp commented 4 years ago

Can you share a repo for me to reproduce the issue?

HeyndrickxKarel commented 4 years ago

Ofcourse.

https://github.com/HeyndrickxKarel/test-reorderable-repeat

I have also noticed just now that when I use bcx-aurelia-reoderable-repeat version 1.3.0 I get the opposite result. Now inserting into an empty array triggers that array's event. But removing the last element of an array doesn't trigger that array's event.

3cp commented 4 years ago

I will test it out tomorrow.

3cp commented 4 years ago

Yes, I can repeat your issue. Fixing.

3cp commented 4 years ago

Fixed in v1.3.5.

HeyndrickxKarel commented 4 years ago

Awesome!