Plugin does not work with aurelia when using dist >= es2015

[josundt]

I have an app using aurelia 1.0 with webpack/aurelia-webpack-plugin.

The aurelia-webpack-plugin has a dist setting that lets you decide which distribution/transpiled ES target from the aurelia packages/plugins to pick when bundling.

Aurelia uses the following convention for subfolder layout in their own packages and also recommend this for plugin creators::

• native-modules: esm/es5
• es2015: esm/es2015
• es2017: esm/es2017
• es20**: esm/es20**

The aurelia-webpack-plugin dist setting lets you choose which target to include when bundling. This works for aurelia-* packages and should also work for aurelia plugins that follow the package folder layout convention.

I recently tried to change the aurelia-webpack-plugin setting from native-modules to es2017, but then the reorderable-repeat plugin failed. Everything else actually works like charm.

I found that the reason is that the reorderable-repeat plugin is only transpiled to es5, and the code also expects the aurelia AbstractRepeater to be using the prototype pattern (not es2015+ class) when the ReorderableRepeat attempts to extend it. This would not have been a problem if the ReorderableRepeat was transpiled to es2015+ with Babel.

Transpiled code from reorderable-repeat.js:

function ReorderableRepeat(ea, taskQueue, bindingEngine, dndService, viewFactory, instruction, viewSlot, viewResources, observerLocator, strategyLocator, groupMap) {
    var _this;

    // This line fails:
    _this = _AbstractRepeater.call(this, {
      local: 'item',
      viewsRequireLifecycle: (0, _aureliaTemplatingResources.viewsRequireLifecycle)(viewFactory)
    }) || this;

Proposed solution:

• Transpile to different targets using Babel (f.ex. es5, es2015, es2017), and follow aurelia's folder layout convention.
• Release new version of the package with all the targets included in the expected subfolders.

I would really appreciate if you could look into this. It should not be a to big effort to extend the lifespan of this useful plugin 👍

[3cp]

Thx for the interesting finding! This could affect some other plugins if they extend core classes.

[3cp]

Tested v1.5.0, works with or without dist rewrite now.

I skipped two dist folders (amd, system) because nobody needs to use them.

[josundt]

Tested upgrading and now everything works like charm! Thanks for the extremely low response time! 🙂 I find it heart warming whenever I witness open source projects where maintenance is taken seriously!