Rename functions that deal with protobuf

buttplugio / buttplug-rs-ffi

FFI from buttplug-rs to Java and other languages

Other

88 stars 22 forks source link

Closed kitlith closed 3 years ago

kitlith commented 3 years ago

Closes #64

While working on this, I noticed:

buttplug_create_log_handle doesn't take a context parameter for the callback? this may be intentional, and it's okay if it is.
the wasm exports still have the old log handling

Potential suggestion: instead of create_protobuf_client, maybe there could be a separate "attach system callback to client" function?

feel free to close or edit if the names don't quite fit.

kitlith commented 3 years ago

i don't think i touched the code that's failing on c#, so... that's another thing.

qdot commented 3 years ago

i don't think i touched the code that's failing on c#, so... that's another thing.

Yeah, you didn't, that's my CI settings being wrong. >.>