search

buttplugio / buttplug-rs-ffi

FFI from buttplug-rs to Java and other languages
Other
88 stars 22 forks source link

Convert public fields to public properties in C# classes #75

Closed Yoooi0 closed 3 years ago

Yoooi0 commented 3 years ago

Feature Description

Any public facing fields should ideally be converted to a public property. Properties are used in some places but not everywhere, example: https://github.com/buttplugio/buttplug-rs-ffi/blob/bf4463a68ba67d89113c2995a1eab2eab006b2c9/csharp/ButtplugCSharpFFI/ButtplugClientDevice.cs#L22-L27

Having Name as a field prevents WPF bindings.

qdot commented 3 years ago

Landed in C# v2.0.2