Closed qdot closed 4 years ago
This relates to buttplugio/buttplug-csharp#14. No relevant buttplug-js bug yet.
@blackspherefollower Any thoughts on if BatteryLevelReading (and RSSILevelReading and RawReading) include the device index they're coming from? It seems extraneous, since that was sent in the request and we'll always match the message back either by ID or stack return resolution. But when we start implementing subscriptions for updates, we'll have to pack device indexes with those since there won't be a matching request.
Seems like always including the device index sets up a good pattern for subscriptions, so I think it might be worth it.
Implemented in v2
Name of Outgoing Message, if any: BatteryLevelCmd
Name of Incoming Message, if any: BatteryLevelReading (?)
Message Fields
Describe message usage scenario Mostly useful for Bluetooth devices, since BLE devices usually have battery level output
Additional context Not sure about the incoming message name here. I'd like to standardize on something like input like we have "Cmd" for output, but I'm not sure what. Choices so far:
BatteryLevel is used versus just Battery, as we might later be able to have something like BatteryTime.