search

buttplugio / buttplug

Rust Implementation of the Buttplug Sex Toy Control Protocol
https://buttplug.io
Other
846 stars 63 forks source link

Sensor range is unsigned, but sensor reading is signed #598

Open CAD97 opened 7 months ago

CAD97 commented 7 months ago

Describe the bug

Expected behavior

The sensor range and sensor reading should have the same signedness.

Actual behavior

The sensor range is an unsigned quantity and the sensor readings are signed quantities.

Additional context

The Protocol Spec says that the reading is array of signed int, and that the range info is array of array of integer (i.e. it doesn't explicitly specify signed or unsigned). The schema suggests that the reading is in the range 0..=255.

qdot commented 7 months ago

Yeah it's supposed to be signed.

However although the messages are defined, they're not really used at this point due to #535. There's some upcoming work to fix that, at which point we'll be doing more sensor implementation too.

qdot commented 3 months ago

These are getting updated to i32's as part of the new config format work.