search

buunguyen / fasterflect

.NET Reflection Made Fast and Simple ⛺
https://www.nuget.org/packages/fasterflect/
Apache License 2.0
285 stars 57 forks source link

Support for .Net Standard20 #11

Closed benskid closed 4 years ago

benskid commented 4 years ago

Updated all projects other than the unit test project to .Net Standard 2.0. Note this breaks compatibility with .Net Framework <4.7.

Updated the unit test project to .Net Framework 4.7.1 since UT cannot be done from a netstandard project. All UT is passing.

Had to remove two methods form EmitHelper, please review. Work left: Update version number and release nuget package. Can you help with this?

buunguyen commented 4 years ago

@benskid thanks for this. Would you mind I add you as a collaborator on NuGet so that you can build and publish an update version?

buunguyen commented 4 years ago

The changes LGTM btw.

benskid commented 4 years ago

@benskid thanks for this. Would you mind I add you as a collaborator on NuGet so that you can build and publish an update version?

Sure, that'd be fine.

buunguyen commented 4 years ago

Thanks, what is your nuget email?

buunguyen commented 4 years ago

Is your NuGet username benskid? After you build the package and before publishing, would appreciate if you send the PR with all the changes so that the repo is sync'ed.

Please bump up the major version since this is a breaking change.

Thanks again for working on this.

benskid commented 4 years ago

My Nuget username is bernarddijk. Changes are in the commit above.

buunguyen commented 4 years ago

Thanks. I've just added your account to Nuget.

buunguyen commented 4 years ago

Also added you as collaborator of this repository.

benskid commented 4 years ago

I've just added your account to Nuget.

Not that I can tell; I tried uploading the updated package but was unable. Can you double check?

buunguyen commented 4 years ago

I think you have to accept the invitation. There should be an email sent to the address associated with your Nuget.