mongoose 5.x fix - uses native promise

buunguyen / mongoose-deep-populate

Mongoose plugin to enable deep population of nested models ⛺

MIT License

469 stars 44 forks source link

mongoose 5.x fix - uses native promise #54

Closed simllll closed 6 years ago

simllll commented 6 years ago

fixes #53 , but also breaks compatibility with mongoose < 4.1 I guess. Did't find it necessary to support a very outdated version.

see https://github.com/Automattic/mongoose/commit/938dd09d3a52f10e832929a52292a2c5b6c6f5e8#diff-4a48b88ee83836bf1814374d04bc3bbc why this change is necessary

buunguyen commented 6 years ago

Thanks! In this case, it shouldn't be that hard to maintain backward compatibility, so I'd prefer to support it. Gonna merge and make the change myself.

buunguyen commented 6 years ago

Interesting, all the tests fail.

buunguyen commented 6 years ago

Gonna revert the changes. If you can fix the tests, please open a new PR.

simllll commented 6 years ago

have seen you did it already,thanks for your quick response and the new release!