search

buunguyen / mongoose-deep-populate

Mongoose plugin to enable deep population of nested models ⛺
MIT License
469 stars 44 forks source link

Allow exec to work with async callbacks #70

Closed epicfaace closed 4 years ago

epicfaace commented 4 years ago

Otherwise, code like the following doesn't work:

PassSubscription.findOne({}).deepPopulate("_owner").exec(async function (err, passSubscription) {
    // callback code here
  }));
buunguyen commented 4 years ago

Thanks. Please move the test under describe(type + ' Using default options') and rerun. It should work for all call patterns, not just the exec.

buunguyen commented 4 years ago

Thanks, published 3.2.0

buunguyen commented 4 years ago

Hi, which node version did you use to run the test?

epicfaace commented 4 years ago

@buunguyen I didn't run the test -- I had some issues setting up things locally. I had assumed that Travis CI would have caught something if the tests didn't work, though?

buunguyen commented 4 years ago

Yeah, the test failed on Travis