buy / tip-calculator

0 stars 1 forks source link

[Groupon iOS bootcamp] Pre-work - Submission by Chang Liu #1

Open buy opened 9 years ago

buy commented 9 years ago

/cc @codepathreview

Hi, this is my pre-work for Groupon iOS bootcamp.

I haven't finished all the optional features yet, but I am not sure whether I will have time to finish them by the deadline since I will be traveling for the rest of the week.

I will try to complete all the optional tasks if I got the chance. Submitting it for now since in the email they mentioned 'The earlier you complete the project, the better'.

Thank you!

nickai commented 9 years ago

Nice work Chang! Great to see you add a slider to your UI. This was intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn all practical iOS development and best practices as quickly as possible. We also do a code review for each submitted project. Nice job with the project, hope you found it as a helpful introduction.

We are reviewing the submissions right now and will get in touch with you via email a few days after the submission closing date, October 2nd, 2015. If you end up having time, feel free to continue working on any extensions to your tip calculator app and just add a comment to this issue if you decide to do so.

buy commented 9 years ago

@nickai thanks for the review!

I just updated the repo with Remembering the bill amount across app restarts (if <10mins), will try to work on the rest of the extensions tomorrow.

Thank you :)

/cc @codepathreview

nickai commented 9 years ago

Nice! Great to hear you continue to extend your app!

buy commented 9 years ago

@nickai Finished all the required and optional tasks, and also added some extra features by myself.

Ready for review :tada:

/cc @codepathreview

Thank you!

nickai commented 9 years ago

Your app looks great! I especially like the attention to detail of changing the tint color of the slider based on the value. Since the class doesn't start for a couple more weeks, I encourage you to check out some tip calculators in the app store to get ideas of how you can take your tip calculator even further. Exploring different parts of iOS on your own is a great way to maximize your learning once the course starts.