buybackoff / 1brc

1BRC in .NET among fastest on Linux
https://hotforknowledge.com/2024/01/13/1brc-in-dotnet-among-fastest-on-linux-my-optimization-journey/
MIT License
437 stars 43 forks source link

Re-run .NET implementation (pedrosakuma) #10

Closed pedrosakuma closed 8 months ago

pedrosakuma commented 8 months ago

Victor,

When you get the time, could you re-run with my last set of implementations?

https://github.com/pedrosakuma/1brc

Thanks a lot!

buybackoff commented 8 months ago

I'm getting 5.503 vs 5.979 in the table.

Will update the table later.

pedrosakuma commented 8 months ago

Hey Victor

I was expecting a more significant improvement, but i guess that maybe it rely on the hardware.

Thanks anyway!

pedrosakuma commented 8 months ago

Hello Victor.

I think this is my last run, made some improvements. Maybe this time it will show in the execution time.

Thanks in advance.

buybackoff commented 8 months ago

Thanks!

BTW, you code cannot finish on this dataset https://github.com/gunnarmorling/1brc/pull/246#issue-2070971816. Or it just take too long, I could not wait for more than 3 minutes.

pedrosakuma commented 8 months ago

Thanks for the feedback! I didnt know about this generator.

buybackoff commented 8 months ago

Could you, please, try to make it work by tomorrow?

pedrosakuma commented 8 months ago

It seems to be fixed, but had to rollback some performance improvements that made assumptions over the data. But i guess that was the whole point of changing the file. Thanks again for pointing that out

buybackoff commented 8 months ago

See my blog post. You changes to work with 10K dataset made the default case significantly slower - but valid and accepted :)

image