buymeasoda / soda-theme

Dark and light custom UI themes for Sublime Text
https://buymeasoda.github.io/soda-theme/
4.33k stars 518 forks source link

Naming question for fork and suggestion (gotta check this one out) #111

Closed greduan closed 12 years ago

greduan commented 12 years ago

Another addition to this pull request: https://github.com/buymeasoda/soda-theme/pull/110

Is it OK if I call it Compact Soda? I just want it to be a personal version of your theme, which will be a very compact version of this awesome theme, just want to make sure it's OK with the license. :)

I suggest that in line 378, you change the value to the following: [102, 102, 102, 50] I've found that this value is a lot more compatible with a wider range of color schemes. This is related to this commit: https://github.com/Greduan/Greduan-Sublime-Theme/commit/13fd69d675278bf9c5f94d64c75a97276690016d And this commit: https://github.com/Greduan/Greduan-Sublime-Theme/commit/6c49e84d6a593740e2d1027a1d9aae068d03034d

Love the work, keep putting out good updates. :)

Eduan

buymeasoda commented 12 years ago

Hi Greduan,

I'll take a look at the compact ideas, thanks.

One thing you might not have seen that's worth knowing, is there's an outstanding bug in Sublime Text 2 where, if the "tab_min_width" value is smaller than the graphics width used in the tab, and you shrink Sublime with a few tabs open it crashes.

To replicate:

Possibly not a problem as it won't happen unless you have lots of tabs + a small window (the more tabs you've got the wider it will crash), but thought I'd share.

With the name, I'd like to see derivative themes - where they have their own name - to not use "Soda" in their naming. Sorry :)

And another tip that you might like, is the use of "User Theme" capability in ST2.

If you mostly like the base Soda Theme values, but have a few things (like tabs widths) that you want to customise, it makes for an nice way to tweak a theme, without needing to maintain an entire fork.

More details here: https://github.com/buymeasoda/soda-theme/wiki/Theme-customisation

greduan commented 12 years ago

Thanks! I wasn't aware of the User theme capability, I glanced over it and I thought it meant that I could edit the theme file, not actually make small customizations to the theme through it. :P

Thanks for your answer, and I do suggest you change that minimap border property, took me a little while to figure it out. :P

Basically, the current one doesn't well work with warm whites (try the Solarized scheme).

Eduan