search

buymeasoda / soda-theme

Dark and light custom UI themes for Sublime Text
https://buymeasoda.github.io/soda-theme/
4.33k stars 518 forks source link

Tab highlight (blue dot) not functional in ST3 #123

Closed klonuo closed 11 years ago

klonuo commented 11 years ago

Hi, thanks to all involved for providing this package.

I tried ST3 and updated soda-theme from st3 branch. Beautiful again, only that file modification flag is missing. This is on ST2:

screenshot

and on ST3 it just doesn't show if file is modified. Close button is unchanged.

I'm using Windows

evanpurkhiser commented 11 years ago

Was this fixed by setting the highlight_modified_tabs option?

klonuo commented 11 years ago

I just assigned tab-highlight...png images for file dirty state, inside theme file. I'm not sure how "tab highlighting" should work, and I wanted file modified indicator. Perhaps "tab highlight" feature fails to deliver, but I could be easily wrong as today is my second day with ST.

BTW, very interesting editor, Python gives so much power and flexibility, but nothing is perfect. I won't review it here, but I'm always curious how editors provide shell interaction, where ST isn't that great, making simple tasks complicating because of lack of it. Then there are unique features that make exciting working with ST. And of course this theme makes experience more pleasant

buymeasoda commented 11 years ago

The setting for highlighting modified tabs still works, but unlike ST2, Sublime Text 3 currently doesn't appear to dynamically process any settings changes for themes when the User Preferences file is changed.

Instead it only applies them on application restart. The same applies for toggling other theme settings.

If you add the following to your Preferences -> Settings - User file, and then exit and restart sublime, it will work as expected:

"highlight_modified_tabs": true
baur79 commented 11 years ago

"highlight_modified_tabs": true works for me