buymeasoda / soda-theme

Dark and light custom UI themes for Sublime Text
https://buymeasoda.github.io/soda-theme/
4.33k stars 517 forks source link

Problem after latest update #177

Closed ewjoachim closed 9 years ago

ewjoachim commented 10 years ago

Hi,

This is what sublime text + dark soda theme looked like this morning : http://i.imgur.com/OODz7Av.png

with Ubuntu trusty after an upgrade of libtiff and kernel. (Edit : see comments below : system upgrade is quite probably unrelated)

Looks normal again when I disable the Soda theme, (but then the theme is disabled).

I'd be happy to provide additional information, but I don't know what may help. In the meantime, I can't use the theme...

dankempster commented 10 years ago

The same also happens for the OSX build 3062. Let me know if you want further OSX info.

ewjoachim commented 10 years ago

Renamed the issue : according to @dankempster, it's probably linked to a (quiet) soda update that happened at the same time as my system upgrade, so is probably a soda latest version issue, unrelated to linux/libtiff/...

andyone commented 10 years ago

@ewjoachim I have same problem on Windows 8.

filhocodes commented 10 years ago

@ewjoachim @andyone Same problem with me (Windows 8.1)

NicolaeNMV commented 10 years ago

Same problem on OSX, I thought it's the coffee I have spilled on my laptop few moments before seeing this bug ;)

owzim commented 10 years ago

Having the same problem on OSX 10.9.2 with Stable Build 3059 and Dev Build 3062.

jesseleite commented 10 years ago

Me too, OSX, ST3 build 3059. I had to disable the theme for now :(

diegocastro commented 10 years ago

Can confirm the bug with my ubuntu 14.04 and sublime 3.

diegocastro commented 10 years ago

Check if the theme is not being ignored. I don't know why but this morning Package Control put soda theme on the ignored list. Check this link https://github.com/buymeasoda/soda-theme/wiki/Troubleshooting#check-ignored-packages-settings

buymeasoda commented 10 years ago

This is an unfortunate side affect of the way bundled packages update in Sublime Text.

Check your Ignore Packages list in your User Preferences file.

Sublime Text will move a package into this area temporarily when updating the package. In some scenarios, it will fail to move the package back out of the ignored list when the update is complete, causing the package to not be available for use.

Open your User Preferences file Sublime Text -> Preferences -> Settings - User, and remove any entry for Soda Theme if one exists in the ignored packages array.

Example of incorrect settings

"ignored_packages":
[
    "Theme - Soda"
]

More troubleshooting help: https://github.com/buymeasoda/soda-theme/wiki/Troubleshooting

So far, there doesn't seem to be a clean way to avoid the UI glitching for an in place update to an active theme.

Hope that helps.

filhocodes commented 10 years ago

Yeah, it's ignored in my ST too

owzim commented 10 years ago

@diegocastro @buymeasoda thanks, that helped.

buymeasoda commented 10 years ago

This tends to happen a lot with theme updates.

My understanding of the flow is:

The good news is it's just some visual noise, but this happens with almost every update since the change to package bundling.

I posted some feedback about it here originally, in the section on upgrading: https://www.sublimetext.com/forum/viewtopic.php?f=2&t=12456

Next time I'll add a note to the changelog that appears on package update with details, but if anyone knows how to avoid this altogether, please let me know.

jotbe commented 10 years ago

Unfortunately, this approach does not work on my system. Soda Dark (3) was causing the graphic glitches at first and it is not listed in the "ignored packages" array. I'm running Sabayon Linux with Gnome 3 and ST2. I noticed that it is also happening with other random themes as well.

jotbe commented 10 years ago

I think the issue is solved for me. I backup the ~/.config/sublime-text-2 directory, let ST2 create a new one and copied the packages in batches from the backup to their regular location. After each batch I opened ST2 to check if the display is still okay. Many themes work again, e.g. Soda Dark, Soda Dark 3 won't work though (at least not in ST2).

buymeasoda commented 10 years ago

Soda Dark 3 won't work though (at least not in ST2).

The theme files with the 3 in their name are only for Sublime Text 3.

jesseleite commented 10 years ago

@buymeasoda Ahh I see. I re-enabled Soda, restarted ST3, and I am good again. It must've just needed to update it's stuff. You're right... not as seamless as it could be ;) Anyway thanks!

PS. Unrelated to topic, but I enabled "soda_folder_icons": true. I assume I need the new dev build 3062 to get the new folder icons?

jgpippin commented 10 years ago

I'm unable to get the soda folder icons in ST3, with or without soda_folder_icons set to true.

kreeger commented 10 years ago

@jgpippin & @JerseyMilker — I wasn't able to get the folder icons using soda_folder_icons: true until I updated to the latest dev build (3062). Then they started working.

buymeasoda commented 10 years ago

I'm unable to get the soda folder icons in ST3, with or without soda_folder_icons set to true.

Sublime Text 3 (Build 3062) added new support for sidebar file / folder icons.

soda_folder_icons remains relevant for ST2, but Soda Theme for ST3 was updated to use this new functionality, and to correct UI issues that resulted from the change.

It's tricky handling theme issues across the versions of ST3, because theme rule changes can leave old versions with console warnings, or new versions with a broken looking UI.

I tend to optimise for the latest available versions of ST2 and ST3.

jgpippin commented 10 years ago

I can appreciate that. And I certainly appreciate all the work you do on this for free.

That said, if you happen to think about it, including the fact that you optimize for dev builds and not stable builds in the readme.md would have saved me about an hour of trying to figure out what was wrong with my installation.

buymeasoda commented 10 years ago

That said, if you happen to think about it, including the fact that you optimize for dev builds and not stable builds in the readme.md would have saved me about an hour of trying to figure out what was wrong with my installation.

I feel the readme is pretty clear on it.

Installation: https://github.com/buymeasoda/soda-theme#installation

Installation

Soda theme is designed to work with the latest development builds of Sublime Text, including Sublime Text 2 and Sublime Text 3

Development: https://github.com/buymeasoda/soda-theme#development

Development

Please note, Sublime Text dev builds move quickly and changes can occur with the theme API between releases, so there may be occasions where the theme doesn't quite work with a brand new dev release.

Which was first added about 3 years ago (https://github.com/buymeasoda/soda-theme/commit/9c008b23880dd13097eaca9051a86c8ee5811884)

I'm bummed that it messed you around though.

I think one thing I can do is add Package Control messaging with future releases, to outline changes and potential issues across ST builds that could result from the update.

markhaehnel commented 10 years ago

Sublime Text console says the following to me:

Errors parsing theme: Animated properties must have both target and speed specified theme loaded

image

buymeasoda commented 10 years ago

Regarding the console warning, please see: https://github.com/buymeasoda/soda-theme/issues/178#issuecomment-42729375

jesseleite commented 10 years ago

Weird. I have build 3059 on both my home office and work computers. My computer here at work shows sidebar folder icons, whereas my computer at home does not. I don't expect technical support on this... I understand Sublime and theme upgrades are not perfect now :) I just thought it was weird though.

MattDMo commented 10 years ago

@buymeasoda Is there a way to disable folder icons in Build 3062? I have "soda_folder_icons": false in my Preferences but they're still showing up...

bofm commented 10 years ago

@MattDMo +1, I have the same issue. Windows.

buymeasoda commented 10 years ago

Not at the moment, the setting remains for ST2.

The previous folder implementation replaced the disclosure arrow icon with a folder icon. With the new icon support two icons render, an arrow and a folder.

There may be a way to collapse the second icon away to return to only the arrow, but the folder icon also shows the loading indicator.

I can take a look into this, but for now the option is ignored in Soda for ST3.