Add support for new sidebar icons

[billdami]

ST3 Build 3065 introduces sidebar icons for folders and files, however it looks like Soda Dark is not fully compatible with this change as only folders show the new icons, not files:

Also, imo the way that the folder icons were implemented, displaying both the caret AND a folder icon next to it, is a bit ugly and wastes space. Is there any way soda theme could modify this to only show one or the other?

[createproblem]

:+1:

[kachar]

:+1: Actually there are two files to be added to the archive with the correct names. The new build requires icons/folder.png and icons/folder_open.png in the theme folder(archive).

[billdami]

Just noticed in issue #174 @buymeasoda does partially address this issue, basically ST currently does not let you specify different file icon paths within a single package, so he just left out the file icons completely for now. However, I did find a snippet to customize the theme which removes the empty space where the file icons should be (and also removes the new folder icons as well):

{
    "class": "icon_file_type",
    "content_margin": [0,0]
},
{
    "class": "icon_folder",
    "content_margin": [0,0]
},
{
     "class": "icon_folder_loading",
     "content_margin": [0,0]
}

I wonder if maybe at least the icon_file_type customization should be added to the Soda themes, until proper file type icon support is added.

[adrianorsouza]

The support sidebar icons for ST3 3065 it's more readable IMO Soda Theme could use this icons as default instead.

[billdami]

@adrianorsouza Those would work for the Soda Light theme, but as you can tell from my screenshot above, you can barely see the folder icon against the dark background.

[adrianorsouza]

@billdami Yep I see, I did not realise that sorry, anyway what I did to get this working was to follow this comment download the icons, make them a better look for Dark theme and place them within the Theme - Soda folder, now it looks better like this:

If you wish I pushed these icons to my fork https://github.com/adrianorsouza/soda-theme/commit/5430e6a5212a0e11dead6fd841f9db87b0f5848f

[billdami]

@adrianorsouza Those icons work quite nicely, thanks! :-)

[nicklangridge]

Also, imo the way that the folder icons were implemented, displaying both the caret AND a folder icon next to it, is a bit ugly and wastes space.

+1

[JTallis]

@adrianorsouza those are very nice and I had a look at your fork. Soda Dark 3.sublime-theme was using the light icons instead of dark. Also, the sidebar file icons used the light icons too.

[adrianorsouza]

@JTallis because the sidebar icons feature of recent ST3 build only looks for a folder named icons there is no way that I know to use separated folders for having both Dark and Light sidebar icons, that was my workaround because I use the Light theme I had to place Light icons within the icons folder, if you intend to use Dark theme icons you need to rename icons_dark to icons.

[Stanzilla]

You guys can try this theme, it is basicly soda dark with support for the native file icons in ST3 https://github.com/Miw0/sodareloaded-theme

[nicklangridge]

@Stanzilla, thanks this looks good