Build 3127 breaks theme

buymeasoda / soda-theme

Dark and light custom UI themes for Sublime Text

https://buymeasoda.github.io/soda-theme/

4.33k stars 517 forks source link

Build 3127 breaks theme #213

Open antstorm opened 7 years ago

antstorm commented 7 years ago

Hey guys,

Just installed today's new release (build 3127) and looks like Soda theme has some issues.

Tabs look like the default ones:

Side bar won't show anything:

Command palette looks a bit off:

My bet is API incompatibility… but I'm no expert in this.

Would really appreciate if someone could have a look?

Soda has been my favourite theme for many years now and I haven't seen anything out there that can compete with it.

P.S. No errors appear in console P.P.S Running on OS X

sdemura commented 7 years ago

Build 3128 on OS X has a working sidebar, but the tabs default to "classic" now, with no way to change them back it seems.

mmacomber0 commented 7 years ago

I too was bothered by the default tabs coming back on dev build 3127 (through 3129) Looking at Will's comment on the Dev Build 3127 discussion ( https://forum.sublimetext.com/t/dev-build-3127/27213/133 ), it looks like the texture for the tab wasn't getting set properly, but he'll have a fix for it in the next dev build. Fingers crossed!

zertosh commented 7 years ago

Actually seems like Sublime is not assuming false for settings that it doesn't recognize. If you add this to your Preferences.sublime-settings, it looks ok again:

    "soda_retina_fix": false,
    "soda_classic_tabs": false,

antwan commented 7 years ago

Anyone having an issue with tabs not scrolling ?

Kronuz commented 7 years ago

tabset_control needs to be like this now for tabs scrolling to work:

    {
        "class": "tabset_control",
        "settings": ["mouse_wheel_switches_tabs", "!enable_tab_scrolling"],
        "mouse_wheel_switch": true
    },

benpbolton commented 7 years ago

Confirming that @Kronuz ' edit works (eg. from Soda Light 3.sublime-theme):

screen shot 2017-04-20 at 9 45 19 am

antwan commented 7 years ago

Great fix thanks, that should be added to the codebase.