search

buymeasoda / soda-theme

Dark and light custom UI themes for Sublime Text
https://buymeasoda.github.io/soda-theme/
4.33k stars 517 forks source link

Build 2210 on OS X 10.7.4: No edit-indicator on tab #82

Closed unphased closed 12 years ago

unphased commented 12 years ago

The indicator (the "x" changes to a dot) is not present on the tab anymore with this theme enabled.

benweier commented 12 years ago

This is a settings issue.

Add this line to your Preferences file

"highlight_modified_tabs": true

unphased commented 12 years ago

This worked great. Thanks.

I'm wondering why this is not enabled by default.

evanpurkhiser commented 12 years ago

It's a preference thing.

Personally I prefer it without the X since I use the keyboard to manage my tabs, and I think the X looks a little bit too much like the dirty indicator dot making it hard for me to to discern what files are actually changed.

Never mind I seem to have mis-read the issue.

If you have figured out your problem you can close this issue =)

unphased commented 12 years ago

I think it is an issue that it isn't on by default! It used to be. Why not anymore?

benweier commented 12 years ago

Whether it's on or off isn't an issue with Soda but with Sublime. We'd be better off asking Jon on the official forums

buymeasoda commented 12 years ago

Hi folks,

This has changed a few times which can be confusing. I'm hoping to resolve the challenges with the modified tabs indicator soon.

What I'm thinking of doing is having the subtle indicator always on by default, and use the highlight_modified_tabs setting as a way for people who prefer a more prominent indicator to turn on a stronger / more distinct version.

unphased commented 12 years ago

Does a more prominent indicator option exist now?

benweier commented 12 years ago

If a prominent modified indicator is highly desired, I've found that turning show_tab_close_buttons off makes it easier to spot unsaved tabs. I use ctrl-w or middle-click to close tabs so I haven't missed the close button at all :)

unphased commented 12 years ago

Fantastic!!!!!

This is perfect. I always hate when I click the close button accidentally as I quickly click through my tabs. Clicking a modified indicator still gets interpreted as a close command but it provides a confirmation menu so it is safe.

This brings the editor that much closer to nirvana.

buymeasoda commented 12 years ago

An update on this issue.

1) The basic indicator now displays by default when tabs have unsaved changes, separate to the highlight_modified_tabs setting. This matches the behaviour implemented in the Default Sublime Text 2 UI theme.

2) The highlight_modified_tabs setting will now be used to trigger a more prominent and distinct indicator for people who want stronger visual feedback on modified tabs status.

Currently, I've updated Soda Dark to implement part 1) above, so it will always display the basic indicator, but I have not yet implemented the additional stronger indicator for part 2) above. This will come with the work I'm doing to Soda Dark for cleaning up the UI and the retina resolution graphics. Not too far away.

Soda Light implements both 1) and 2). With a base / subtle indicator displaying for edited / unsaved tabs, and an optional stronger indicator available via the highlight_modified_tabs settings.

Hopefully this will work for most people. It matches more closely the Default theme behaviour and allows people to use the highlight_modified_tabs setting to ramp up the obviousness.

buymeasoda commented 12 years ago

I'll close this issue as it related to the display of the indicator by default. There's another issue open for making the indicator (or tab text) more prominent if there's additional discussion for that.