search

buymeasoda / soda-theme

Dark and light custom UI themes for Sublime Text
https://buymeasoda.github.io/soda-theme/
4.33k stars 518 forks source link

No such prop dark_content #84

Closed Xavura closed 12 years ago

Xavura commented 12 years ago

I get this message in the python console all the time. It seems to happen only, or at least more, when I'm typing.

buymeasoda commented 12 years ago

Found the issue and will be able to push a fix soon :)

Xavura commented 12 years ago

Very nice. :thumbsup:

What is the issue if you don't mind taking a minute to explain it, purely out of curiosity?

buymeasoda commented 12 years ago

No worries, here's the details.

There is a property available for theming to trigger the different overlay scrollbars that some operating systems have. For example, in OS X the overlay scrollbar can appear translucent black when displaying over lighter backgrounds, and translucent white when displaying over darker backgrounds.

For ST2, this can be set using the property "dark_content" to trigger the translucent white overlay scrollbar. You can see these scrollbars in action for Soda Dark in the sidebar and the Command Palette / Goto Anything box.

The instance that is causing the console error is for the code completion popup, which doesn't look to implement the setting for it's scrollbar. This is also why you're seeing the error mostly when typing. I'm not sure if this is a regression in ST2 core, or just a case where I expected the option to be available and no one saw or reported the error ;)

I'll have to see if Jon can shed some light on that and ideally allow support for it, because I'd like to be able to trigger the light overlay scrollbar for this element in Soda Dark.

For now I'm just going to comment it out to stop the console error occurring until it hopefully gets fixed or added.

Xavura commented 12 years ago

I thought it might have something to do with the code completion. I was surprised it hadn't been reported yet with the frequency of the error. I actually noticed it a while back but forgot to report it.

Thanks for the quick reply/explanation.

buymeasoda commented 12 years ago

I've pushed the change that fixes this issue.