test.mt/configure.ac: quote usage of AC_SEARCH_LIBS

buytenh / ivykis

GNU Lesser General Public License v2.1

24 stars 18 forks source link

test.mt/configure.ac: quote usage of AC_SEARCH_LIBS #27

Closed ArsenArsen closed 7 months ago

ArsenArsen commented 1 year ago

Bug: https://bugs.gentoo.org/871753

Hey there!

When backporting some upcoming fixes for Clang 16 into autoconf 2.71, we ran into some quoting issues in the test.mt/configure.ac autoconf script. Upstream added a commit that put a comma in one of the comments, which would lead to it, due to improper escaping, botching the libs= assignment it emits to include a bunch of C code. This patch appears to resolve all quoting issues.

Thanks!

bazsi commented 11 months ago

I just tested this with autoconf 2.71

autoconf ran without errors, I did a test-build of ivykis and also run the test suite. The patch looks good to me.

With that said, this should be ready to be merged.

buytenh commented 7 months ago

I've rebased this commit onto master and merged it as 35659deaf813, where it is part of the v0.43 release. Thank you!

ArsenArsen commented 7 months ago

thanks!