search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 128 forks source link

Dev watson #177

Closed brendonw1 closed 6 years ago

brendonw1 commented 6 years ago

Fixed some more issues of saving and statescoring in new cases that came up in the lab

brendonw1 commented 6 years ago

Of note... this is my personal main working branch... so I had merged it with some other changes too. i'm not sure how to manage that case when there are multiple pull requests outstanding but I know the code works for me and so I want to use the pull-requsted code ... I have to integrate it somewhere. Maybe I make a new "working" branch for my lab... since master is really something else?

dlevenstein commented 6 years ago

Yeah, I think it's good to have a "working" (or personal dev) branch on your fork. Is there any code in this PR we shouldn't pull into buzsakilab/buzcode?

brendonw1 commented 6 years ago

All the other stuff I synced are from other buzcode branches. Like catching up with master and dev On Fri, Apr 6, 2018 at 7:02 PM Dan Levenstein notifications@github.com wrote:

Yeah, I think it's good to have a "working" (or personal dev) branch on your fork. Is there any code in this PR we shouldn't pull into buzsakilab/buzcode?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/177#issuecomment-379406397, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTZ1JnqOcH4o3nIgQaI4-uXdl7CRAks5tl_QIgaJpZM4TKb0G .

dlevenstein commented 6 years ago

Nice. Feel free to merge it - I'm on my phone and can't from here

On Apr 6, 2018, at 7:10 PM, Brendon Watson notifications@github.com wrote:

All the other stuff I synced are from other buzcode branches. Like catching up with master and dev On Fri, Apr 6, 2018 at 7:02 PM Dan Levenstein notifications@github.com wrote:

Yeah, I think it's good to have a "working" (or personal dev) branch on your fork. Is there any code in this PR we shouldn't pull into buzsakilab/buzcode?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/177#issuecomment-379406397, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTZ1JnqOcH4o3nIgQaI4-uXdl7CRAks5tl_QIgaJpZM4TKb0G .

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

brendonw1 commented 6 years ago

I merged it... check it out sometime