buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 128 forks source link

check that buzcode - phy interact properly #225

Open AntonioFR8 opened 6 years ago

AntonioFR8 commented 6 years ago

Check that io functions converge into the same output structures no matter which clustering software or behavioral tracking was used. Basic functions already exist but there are some inconsistencies and some io are too specific to certain recording conditions (i.e. cameras configuration) As this is the very first step to start using buzcode it should be very streamlined and well explained

brendonw1 commented 6 years ago

We will certainly get to this - but I'm not sure precisely when. Could be soon (I hope). Thank you for initating this

AntonioFR8 commented 6 years ago

I was planning to start now, at least with the things I'm going to use first and are giving some problems, like importing phy spikes and optitrack

brendonw1 commented 6 years ago

Awesome. We'll be there with you as of some point.

DavidTingley commented 6 years ago

94 addressed some of this, for older formats than phy.

@AntonioFR8 for behavior the pos2behav function works well for converting the Nx5 (or Nx11) .pos files into a *.behavior.mat file/struct. Check the file header for a description of what to export from optitrack

AntonioFR8 commented 6 years ago

Thanks David, I did not know about this function. I was using bz_processConvertOptitrack2Behav.m https://github.com/buzsakilab/buzcode/blob/master/preprocessing/positionTracking/optitrack/bz_processConvertOptitrack2Behav.m and found some problems.

Why are these 2 functions and also Process_ConvertOptitrack2Pos.m https://github.com/buzsakilab/buzcode/blob/master/preprocessing/positionTracking/optitrack/Process_ConvertOptitrack2Pos.m, it seems they do almost the same. Which do you use. We can remove/consolidate those that are redundant.

On Mon, Jul 30, 2018 at 11:50 AM, David Tingley notifications@github.com wrote:

94 https://github.com/buzsakilab/buzcode/issues/94 addressed some of

this, for older formats than phy.

@AntonioFR8 https://github.com/AntonioFR8 for behavior the pos2behav https://github.com/buzsakilab/buzcode/blob/master/utilities/fileConversions/pos2behav.m function works well for converting the Nx5 (or Nx11) .pos files into a *.behavior.mat file/struct. Check the file header for a description of what to export from optitrack

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/225#issuecomment-408912359, or mute the thread https://github.com/notifications/unsubscribe-auth/AM8oQ9R6mmF3hJCU7j3oTI6iPJPEFkbcks5uLys_gaJpZM4VcA7c .

-- Antonio Fernandez-Ruiz, PhD Sir Henry Wellcome Post-doctoral fellow Buzsaki Lab. NYU Neuroscience Institute New York University, Langone Medical Center East River Science Park, 450 East 29th Street, 9th Floor New York, NY 10016

DavidTingley commented 6 years ago

use bz_processConvertOptitrack2Behav.m, bz_processConvertOptitrack2Pos.m was written when we were transitioning and I needed something fast (It has a deprecation warning now, we can remove it now/in the future).

AntonioFR8 commented 6 years ago

ok, but the way that function reads the columns of the csv file is not the same as pos2behav does, and only the later is accurate for me. either we change this and keep the way is done in pos2behav or we make it read the header

On Mon, Jul 30, 2018 at 3:25 PM, David Tingley notifications@github.com wrote:

use bz_processConvertOptitrack2Behav.m, bz_processConvertOptitrack2Pos.m was written when we were transitioning and I needed something fast (It has a deprecation warning now, we can remove it now/in the future).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/225#issuecomment-408981141, or mute the thread https://github.com/notifications/unsubscribe-auth/AM8oQ5qxzF2Z6ML2y2iD9pEcGZpqKQZQks5uL125gaJpZM4VcA7c .

-- Antonio Fernandez-Ruiz, PhD Sir Henry Wellcome Post-doctoral fellow Buzsaki Lab. NYU Neuroscience Institute New York University, Langone Medical Center East River Science Park, 450 East 29th Street, 9th Floor New York, NY 10016

DavidTingley commented 6 years ago

correct. This function was intended to replace bz_processConvertOptitrack2Pos.m and pos2behav.m but isn't finished. Note the error() call on 134.

AntonioFR8 commented 6 years ago

ok, i will finish it then

On Mon, Jul 30, 2018 at 3:38 PM, David Tingley notifications@github.com wrote:

correct. This function was intended to replace bz_processConvertOptitrack2Pos.m and pos2behav.m but isn't finished. Note the error() call on 134.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/225#issuecomment-408984618, or mute the thread https://github.com/notifications/unsubscribe-auth/AM8oQ24uEETs5JMI2aDQkqsIwfKiKm3iks5uL2C2gaJpZM4VcA7c .

-- Antonio Fernandez-Ruiz, PhD Sir Henry Wellcome Post-doctoral fellow Buzsaki Lab. NYU Neuroscience Institute New York University, Langone Medical Center East River Science Park, 450 East 29th Street, 9th Floor New York, NY 10016