search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 128 forks source link

FiltFiltM causes segmentation error core dump #236

Closed brendonw1 closed 6 years ago

brendonw1 commented 6 years ago

Linux machine, Matlab 2017b... every single time I run bz_Filter i get a segmentaiton error core dump. Isolated to the FiltFiltM call and in side that, located to the FilterX call at line 197 of FiltFiltM.m. ANyone had this? I notice in bz_Filter.m the call is to filtfilt rather than FiltFiltM if version 2017a. Could it be that later versions of matlab don't need/work nicely with FiltFIltM??

DavidTingley commented 6 years ago

which version of Matlab? and did compileBuzcode.m run without any errors?

brendonw1 commented 6 years ago

2017b And I re-ran compline buzcode. No errors On Tue, Aug 28, 2018 at 1:14 AM David Tingley notifications@github.com wrote:

which version of Matlab? and did compileBuzcode.m run without any errors?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/236#issuecomment-416453798, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTf_8Ptf35WqsPAZJC1tfoOYONqXTks5uVNHOgaJpZM4WObRy .

dlevenstein commented 6 years ago

Sounds like 2017b has the same issue with FiltFiltM as 2017a. Sad.

brendonw1 commented 6 years ago

I'm trying to gather more info about who put in that 2017a restriction and why... was it this problem? Something else? I can't tell whether to assume this might relate to whyever whoever put that thing in.

dlevenstein commented 6 years ago

this was from issue #179

brendonw1 commented 6 years ago

Ah thank you. Good. So has anyone tried it with 2018? Maybe we can make it so it only works if 2016 or below? I can do it once I know what to do.

brendonw1 commented 6 years ago

Are people ok with my restricting FiltFiltM to only be used if not 2017x?
Btw I haven't found that filtfilt is perceptably slower.

dlevenstein commented 6 years ago

Good for me

On Aug 30, 2018, at 1:50 PM, Brendon Watson notifications@github.com wrote:

Are people ok with my restricting FiltFiltM to only be used if not 2017x? Btw I haven't found that filtfilt is perceptably slower.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

DavidTingley commented 6 years ago

Went ahead and fixed this in bz_Filter, was getting a similar error with MATLAB 2018. Default behavior is now to use the slower filtfilt.m unless specified by the user.