search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 128 forks source link

gather_try.m called in bz_LFPfromDat #245

Open brendonw1 opened 5 years ago

brendonw1 commented 5 years ago

gather_try.m is a part of the kilosort toolbox! Either we should have it in buzcode or take it out of this function. Suggestions?

dlevenstein commented 5 years ago

what does it do? I'm DFW

samamckenzie commented 5 years ago

function x = gather_try(x)

try x = gather(x); catch end

On Mon, Sep 24, 2018 at 1:05 PM, Dan Levenstein notifications@github.com wrote:

what does it do? I'm DFW

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/245#issuecomment-424050391, or mute the thread https://github.com/notifications/unsubscribe-auth/ANnfgBK2AyS2xUifqV6FvkYl59mnowuUks5ueRDPgaJpZM4WxDdl .

dlevenstein commented 5 years ago

That's it.... I mean, we can put it in buzcode if you want or just put it as an internal function in LFPfromDat

DavidTingley commented 5 years ago

It seems that that piece of code would fail even with the try/catch because x is not initialized? I vote for removal if this is part of kilosort

brendonw1 commented 5 years ago

Marius doesn't seem very flexible on kilosort code. I doubt we'll make much progress there and it works.

I just don't know how this got into bz_GetLFP and I vote that whoever put it in fixes it. I don't have time for coding now.

On Wed, Sep 26, 2018 at 7:18 AM David Tingley notifications@github.com wrote:

It seems that that piece of code would fail even with the try/catch because x is not initialized? I vote for removal if this is part of kilosort

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/245#issuecomment-424732604, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTVCY_jibusB0VTTsKh8iP5arjFeUks5ue4ytgaJpZM4WxDdl .