search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 128 forks source link

Combine bz_LoadPhy and ConverPhyKilo2Neurosuite to ensure spike data saved in neurosuite format #263

Closed raswanson closed 5 years ago

raswanson commented 5 years ago

Does this make sense? Seems a good stage at which to impose this so we have standardization of our saved files. Do we care? What this would result in is some people having phy + neurosuite formatted files.

brendonw1 commented 5 years ago

I’m thinking the same function reads both types and outputs a .mat. I’m behind that

On Sun, Oct 28, 2018 at 4:00 PM raswanson notifications@github.com wrote:

Does this make sense? Seems a good stage at which to impose this so we have standardization of our saved files. Do we care? What this would result in is some people having phy + neurosuite formatted files.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/263, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTYJRpfsLpgydMpcJqmM4Arvg1jOEks5upgz1gaJpZM4X-J05 .

dlevenstein commented 5 years ago

I agree - the standardization of the saved files is in the spikes.cellinfo.mat file. We should allow users to be flexible in their "raw" files, but have a single pipeline that loads in to buzcode. (i.e. Issue #261)

raswanson commented 5 years ago

Agreed. To make explicit the two components of this - 1. Standardization should be at the level of buzcode structs (thus someone might have their spike data in phy format, others in neurosuite, and that's fine), because 2. Our basic I/O spikes fx should be able to generate a spikes.cellinfo.mat file from a range of different common file formats (e.g. neurosuite and phy for now - issue #261 ).

brendonw1 commented 5 years ago

Exactly

On Sun, Oct 28, 2018 at 6:48 PM raswanson notifications@github.com wrote:

Agreed. To make explicit the two components of this - 1. Standardization should be at the level of buzcode structs (thus someone might have their spike data in phy format, others in neurosuite, and that's fine), because

  1. Our basic I/O spikes fx should be able to generate a spikes.cellinfo.mat file from a range of different common file formats (e.g. neurosuite and phy for now - issue #261 https://github.com/buzsakilab/buzcode/issues/261 ).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/263#issuecomment-433749711, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTZdRCVHwzevio13FThsY181hoXbiks5upjRNgaJpZM4X-J05 .

dlevenstein commented 5 years ago

Closing - discussion should move to #261