bz_LoadPhy uses base 1 instead of base 0 for labeling channels

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete

http://www.buzsakilab.com/

GNU General Public License v3.0

119 stars 128 forks source link

bz_LoadPhy uses base 1 instead of base 0 for labeling channels #264

Open raswanson opened 5 years ago

raswanson commented 5 years ago

Hey guys - just flagging the fact that:

bz_LoadPhy uses base 1 for identification of the channel of max waveform for each unit (spikes.maxWaveformCh)
bz_GetLFP uses base 0 for channel identification (a la neuroscope)
bz_GetSpikes appears to use base 0 (please confirm @DavidTingley)

We should visit this to make sure all are the same.

brendonw1 commented 5 years ago

Basically going forward it of course makes sense to make bz_LoadPhy use base0 to match. But @AntonioFR8 and others who have already used bz_LoadPhy will need to find a way to make this work for them

raswanson commented 5 years ago

Yeah exactly. We were thinking we'd just have to chat with Antonio/Manu tomorrow to see how much that would break :P