buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
118 stars 128 forks source link

TheStateEditor: overlay not working from SleepState.states.mat file #281

Closed dlevenstein closed 5 years ago

dlevenstein commented 5 years ago

Loading overlay from SleepStates.states.mat file isn't working (using brand new scoring, in dev branch)

dlevenstein commented 5 years ago

Looks like the bug is in line 3214 'Undefined function or variable 'obj''

Will look more when I get a chance

brendonw1 commented 5 years ago

Sub in "FO.fig" for "obj" and it now works. Also 10 lines later it needs a semicolon B

On Tue, Jan 15, 2019 at 2:30 PM Dan Levenstein notifications@github.com wrote:

Looks like the bug is in line 3214 'Undefined function or variable 'obj''

Will look more when I get a chance

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/281#issuecomment-454520423, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTQXiNiicb-pOsSUmjPGt12lhTmnjks5vDixtgaJpZM4aBphn .

brendonw1 commented 5 years ago

By the way, I didn't know this feature was available and it was on my list of things to do in the long run! Thanks

On Tue, Jan 15, 2019 at 2:47 PM Brendon Watson brendon.watson@gmail.com wrote:

Sub in "FO.fig" for "obj" and it now works. Also 10 lines later it needs a semicolon B

On Tue, Jan 15, 2019 at 2:30 PM Dan Levenstein notifications@github.com wrote:

Looks like the bug is in line 3214 'Undefined function or variable 'obj''

Will look more when I get a chance

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/281#issuecomment-454520423, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTQXiNiicb-pOsSUmjPGt12lhTmnjks5vDixtgaJpZM4aBphn .

brendonw1 commented 5 years ago

Would it be OK if we change how this functionality is called upon by the user? Rather than having it be via the "Choose from file" mode, could we make a separate menu option called "Load Autoscore Metrics" or something? That way users will know it's possible.

dlevenstein commented 5 years ago

That would be awesome!

brendonw1 commented 5 years ago

I was hoping you’d do it ;)

On Tue, Jan 15, 2019 at 4:53 PM Dan Levenstein notifications@github.com wrote:

That would be awesome!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/281#issuecomment-454566005, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTT5slIVM4QF04I-lg5U4jNLSIq0Xks5vDk3bgaJpZM4aBphn .

dlevenstein commented 5 years ago

Ooohhhhhhhhhh. Yeah I'll do the thing :p

brendonw1 commented 5 years ago

Whichever of us gets to it first - but that’s likely you

On Tue, Jan 15, 2019 at 5:26 PM Dan Levenstein notifications@github.com wrote:

Ooohhhhhhhhhh. Yeah I'll do the thing :p

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/281#issuecomment-454575802, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTYDVRDSkp1t_wQLuFNXqxPlCxJOHks5vDlWEgaJpZM4aBphn .

dlevenstein commented 5 years ago

This is addressed in #286 - new pull down option!

brendonw1 commented 5 years ago

Sweet :)

On Thu, Jan 17, 2019 at 7:43 PM Dan Levenstein notifications@github.com wrote:

Closed #281 https://github.com/buzsakilab/buzcode/issues/281.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/281#event-2081756409, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTQmk-EZeJ9Bsq4GkjiA9kcCHlJxpks5vERipgaJpZM4aBphn .