search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
118 stars 128 forks source link

DetectSPINDLES function missing? #285

Closed booleannie closed 4 years ago

booleannie commented 5 years ago

I cannot find the DetectSPINDLES function that is referenced in detectors/detectStates/SleepScoreMaster/FindSpindlesAndSWs.m anywhere. This may be due to my inexperience, and if so I apologize in advance if it's not actually missing.

dlevenstein commented 5 years ago

Ah, sorry - FindSpindlesAndSWs.m and DetectSPINDLES.m were unfinished functions that never should have been imported into buzcode. This was discussed in PR #270 and addressed with PR #274 in the dev branch, but has not yet been pulled into master

dlevenstein commented 5 years ago

If you're looking to detect spindles, I know @brendonw1 uses FindRipples, with some modified parameters.

A good spindle detector is sorely needed in buzcode, but no one in the lab has been working with spindles lately, so if you're able to modify FindRipples to optimize for spindle detection, we'd love to add it to the repo

Also, for detecting Slow Waves I recommend DetectSlowWaves

brendonw1 commented 5 years ago

Hi, yeah... we meant to get rid of that FindSpindlesAndSWs.m file... maybe I forgot? Not sure how it's still in there.

As for what we tried - it's not fabulous, but I guess it never is (?).... I think in bz_FindRipples I put something like filter for 10-20Hz, find durations 400-2000ms something like that. You can try viewing the results in EventViewer by the way. We haven't really gone down that rabbit hole though.

On Thu, Jan 17, 2019 at 7:27 PM Dan Levenstein notifications@github.com wrote:

If you're looking to detect spindles, I know @brendonw1 https://github.com/brendonw1 uses FindRipples, with some modified parameters.

A good spindle detector is sorely needed in buzcode, but no one in the lab has been working with spindles lately, so if you're able to modify FindRipples to optimize for spindle detection, we'd love to add it to the repo

Also, for detecting Slow Waves I recommend DetectSlowWaves

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/285#issuecomment-455382499, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTZbCnpLxrpDVum_arXI_xtf0hPSbks5vERT_gaJpZM4aG_PR .

dlevenstein commented 5 years ago

it'll be removed in main once we close PR #287