buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
118 stars 128 forks source link

bz_WaveSpec speedup and RAM improvement #303

Closed dlevenstein closed 5 years ago

dlevenstein commented 5 years ago

Dramatically improved bz_WaveSpec's use of RAM - improves speed and handling of large recording files.

dlevenstein commented 5 years ago

Merging, but let me know if you run into any bugs

AntonioFR8 commented 5 years ago

dramatic improve?! that must be really good

On Fri, Mar 1, 2019 at 12:30 PM Dan Levenstein notifications@github.com wrote:

Merging, but let me know if you run into any bugs

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/303#issuecomment-468745099, or mute the thread https://github.com/notifications/unsubscribe-auth/AM8oQygv08DQav4iQe51JcCJ6CEnE6VDks5vSWO7gaJpZM4bZele .

-- Antonio Fernandez-Ruiz, PhD Sir Henry Wellcome Post-doctoral fellow Buzsaki Lab. NYU Neuroscience Institute New York University, Langone Medical Center East River Science Park, 450 East 29th Street, 9th Floor New York, NY 10016

dlevenstein commented 5 years ago

;)

brendonw1 commented 5 years ago

Anytime someone wants to give me "dramatic improve" I'm happy

On Fri, Mar 1, 2019 at 12:35 PM Dan Levenstein notifications@github.com wrote:

;)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/303#issuecomment-468746420, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTXiJFKqFoaa_y6kPwmJPEmo6vcdcks5vSWTJgaJpZM4bZele .

dlevenstein commented 5 years ago

It was unnecessarily holding two copies of very large matrices in RAM (the lfp and the wavelets)... curious what the actual tic toc improvement is, but files that used to be prohibitive on my machine are now waveletable!