search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
118 stars 128 forks source link

ignoretime feature for sleepscoremaster #315

Closed DavidTingley closed 4 years ago

DavidTingley commented 5 years ago

Not providing any input for this, throws an error due to empty [] interval set.

Error using InIntervals (line 59) Incorrect intervals (type 'help InIntervals' for details). Error in PickSWTHChannel (line 205) ignoretimeIDX = InIntervals(t_FFT,ignoretime); Error in SleepScoreMaster (line 199) SleepScoreLFP = PickSWTHChannel(basePath,...

DavidTingley commented 5 years ago

should be temporarily fixed in acfcf94 though we should consider padding the signal w/ NaNs or zeros rather than removing chunks

brendonw1 commented 5 years ago

Working on fixing this. This is a problem elsewhere too... did the same if~isempty in a few other places

The nan thing might be a good idea too.

dlevenstein commented 5 years ago

The Nan thing would need a complete and unnecessary rewrite of how the algorithm handles ignoreints. Sorry about the empty bug 😬

On Mar 30, 2019, at 9:46 AM, Brendon Watson notifications@github.com wrote:

Working on fixing this. This is a problem elsewhere too... did the same if~isempty in a few other places

The nan thing might be a good idea too.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

brendonw1 commented 5 years ago

Haven’t looked in detail. Does timing get handled ok if ignore time?

On Sat, Mar 30, 2019 at 9:54 AM Dan Levenstein notifications@github.com wrote:

The Nan thing would need a complete and unnecessary rewrite of how the algorithm handles ignoreints. Sorry about the empty bug 😬

On Mar 30, 2019, at 9:46 AM, Brendon Watson notifications@github.com wrote:

Working on fixing this. This is a problem elsewhere too... did the same if~isempty in a few other places

The nan thing might be a good idea too.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/315#issuecomment-478247842, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTSkCFDw7nD6C9G0a0HfrB9GLQKEYks5vb2yIgaJpZM4cRPD8 .

brendonw1 commented 5 years ago

Like are there still “zero” state assignments for those times?

On Sat, Mar 30, 2019 at 10:07 AM Brendon Watson brendon.watson@gmail.com wrote:

Haven’t looked in detail. Does timing get handled ok if ignore time?

On Sat, Mar 30, 2019 at 9:54 AM Dan Levenstein notifications@github.com wrote:

The Nan thing would need a complete and unnecessary rewrite of how the algorithm handles ignoreints. Sorry about the empty bug 😬

On Mar 30, 2019, at 9:46 AM, Brendon Watson notifications@github.com wrote:

Working on fixing this. This is a problem elsewhere too... did the same if~isempty in a few other places

The nan thing might be a good idea too.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/315#issuecomment-478247842, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTSkCFDw7nD6C9G0a0HfrB9GLQKEYks5vb2yIgaJpZM4cRPD8 .

dlevenstein commented 5 years ago

Yup. But that gets handled later. Try it out and double check it works on your end.

On Mar 30, 2019, at 10:08 AM, Brendon Watson notifications@github.com wrote:

Like are there still “zero” state assignments for those times?

On Sat, Mar 30, 2019 at 10:07 AM Brendon Watson brendon.watson@gmail.com wrote:

Haven’t looked in detail. Does timing get handled ok if ignore time?

On Sat, Mar 30, 2019 at 9:54 AM Dan Levenstein notifications@github.com wrote:

The Nan thing would need a complete and unnecessary rewrite of how the algorithm handles ignoreints. Sorry about the empty bug 😬

On Mar 30, 2019, at 9:46 AM, Brendon Watson notifications@github.com wrote:

Working on fixing this. This is a problem elsewhere too... did the same if~isempty in a few other places

The nan thing might be a good idea too.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/315#issuecomment-478247842, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTSkCFDw7nD6C9G0a0HfrB9GLQKEYks5vb2yIgaJpZM4cRPD8 .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

brendonw1 commented 5 years ago

OK good to hear. Thanks for implementing this. I may or may not get to that test - trying to churn through bunch of other stuff

On Sat, Mar 30, 2019 at 10:25 AM Dan Levenstein notifications@github.com wrote:

Yup. But that gets handled later. Try it out and double check it works on your end.

On Mar 30, 2019, at 10:08 AM, Brendon Watson notifications@github.com wrote:

Like are there still “zero” state assignments for those times?

On Sat, Mar 30, 2019 at 10:07 AM Brendon Watson < brendon.watson@gmail.com> wrote:

Haven’t looked in detail. Does timing get handled ok if ignore time?

On Sat, Mar 30, 2019 at 9:54 AM Dan Levenstein < notifications@github.com> wrote:

The Nan thing would need a complete and unnecessary rewrite of how the algorithm handles ignoreints. Sorry about the empty bug 😬

On Mar 30, 2019, at 9:46 AM, Brendon Watson < notifications@github.com> wrote:

Working on fixing this. This is a problem elsewhere too... did the same if~isempty in a few other places

The nan thing might be a good idea too.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub < https://github.com/buzsakilab/buzcode/issues/315#issuecomment-478247842>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ADXrTSkCFDw7nD6C9G0a0HfrB9GLQKEYks5vb2yIgaJpZM4cRPD8

.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/issues/315#issuecomment-478250651, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXrTeRXvs9E4RI_C9j8eDivxrWMqQX-ks5vb3PogaJpZM4cRPD8 .

dlevenstein commented 4 years ago

Closing issue - this is fixed