search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 126 forks source link

updating bz_PhaseModulation and old function to convert phy/kilo to neurosuite #352

Closed eliezyer closed 4 years ago

eliezyer commented 4 years ago

This is to update the bz_PhaseModulation related to issue #324, plus an improvement to an old function I had for converting phy1/kilosort1 to neurosuite format.

dlevenstein commented 4 years ago

looks like there are some conflicting lines that need to be resolved before pulling

eliezyer commented 4 years ago

looks like there are some conflicting lines that need to be resolved before pulling

Just checked, it was a conflict with filter order and older comments from the function. Anyway I kept the original lines of the code

dlevenstein commented 4 years ago

Can we make the filter order be an optional input?

Also, ideally this function calls bz_WaveSpec or bz_Filter (and can thus pass through parameters like intervals, filter parameters, etc), instead of having it hard coded. This can be done later though.