search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 126 forks source link

new place field function vol1 #353

Closed AntonioFR8 closed 4 years ago

dlevenstein commented 4 years ago

addresses issue #302

dlevenstein commented 4 years ago

I just noticed that most of the other structs have params formatted like so:

detectorinfo: substructure with information about the detection method (fields below) .detectorname: name of the function used for detection .detectionparms: parameters used for detection .detectiondate: date of detection

Should we make the structure follow this convention as well?

dlevenstein commented 4 years ago

Also, in general let's give one other person a chance to look through your pull request and merge - that way we get at least one additional set of eyes on code as it gets pulled in.

AntonioFR8 commented 4 years ago

Ok, I will do like that next time.

On Oct 28, 2019, at 9:49 PM, Dan Levenstein notifications@github.com wrote:

Also, in general let's give one other person a chance to look through your pull request and merge - that way we get at least one additional set of eyes on code as it gets pulled in.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/353?email_source=notifications&email_token=ADHSQQ44PLMEGIMVADZUHUTQQ6JCJA5CNFSM4JGBWOYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECO6SFI#issuecomment-547219733, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHSQQ5UBNNFAGPVJWL4MNTQQ6JCJANCNFSM4JGBWOYA.