search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 126 forks source link

bz_RankOrder #369

Closed acnavasolive closed 4 years ago

acnavasolive commented 4 years ago

bz_RankOrder (and its complementary script bz_getSpikesRank) are now finished and ready to be tested. They are stored inside ./analysis/RankOrder/.

buzsakilab commented 4 years ago

Hey Andrea - let's hold off on pulling all these changes into master until we've had time to use them. It looks like they're already in dev.

dlevenstein commented 4 years ago

( Sorry, that last comment was from me - I forgot to log out of the Buzsaki lab account)

acnavasolive commented 4 years ago

Hi Dan! Antonio told me to do a pull request to notify him this was ready, so he could test the code with his analysis. Sorry for the inconvenience!

Andrea

El lun., 18 nov. 2019 a las 19:10, Dan Levenstein (notifications@github.com) escribió:

( Sorry, that last comment was from me - I forgot to log out of the Buzsaki lab account)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/369?email_source=notifications&email_token=AGDT4EFMNUPMMPUYHXWARRDQULLBHA5CNFSM4JOX62QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELMAAQ#issuecomment-555139074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDT4EDYM5PROVRIPDOA4H3QULLBHANCNFSM4JOX62QA .

dlevenstein commented 4 years ago

The code is already in dev so he can try it out there.

acnavasolive commented 4 years ago

Sure!

El lun., 18 nov. 2019 a las 19:14, Dan Levenstein (notifications@github.com) escribió:

The code is already in dev so he can try it out there.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/369?email_source=notifications&email_token=AGDT4EDYK2WZU25ARPWW6TTQULLO7A5CNFSM4JOX62QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELMLUY#issuecomment-555140563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDT4EHG7AY7PIHBXDNWKKDQULLO7ANCNFSM4JOX62QA .

dlevenstein commented 4 years ago

I bet he meant to pull request from your fork into buzsakilab/dev. Pulling from dev into master would bring in all the changes over the last few weeks, before we've all had time to test them and find any bugs/incompatibilities. In general I think it's good practice to do updates on your own fork (instead of the buzsakilab/dev branch) and then pull from your fork into dev.

The git desktop app does have a silly thing where it starts with a branch called "dev" on your fork, that actually makes the updates on the group repository (buzsakilab), so I recommend making a personal dev branch on your fork (e.g. mine is called "DLdev"). We should definitely update the wiki to spell this out more clearly (as part of issue #349)

acnavasolive commented 4 years ago

Oh I see! Again, sorry! I'm so used to use git on my own, and I haven't really been in any group dynamics. I can remove my contributions to dev, go to our branch, add them there, and then make a pull request from that branch to dev. Does that make sense? Thank you for clarifying this for me!

El lun., 18 nov. 2019 a las 19:24, Dan Levenstein (notifications@github.com) escribió:

I bet he meant to pull request from your fork into buzsakilab/dev. Pulling from dev into master would bring in all the changes over the last few weeks, before we've all had time to test them and find any bugs/incompatibilities. In general I think it's good practice to do updates on your own fork (instead of the buzsakilab/dev branch) and then pull from your fork into dev.

The git desktop app does have a silly thing where it starts with a branch called "dev" on your fork, that actually makes the updates on the group repository (buzsakilab), so I recommend making a personal dev branch on your fork (e.g. mine is called "DLdev"). We should definitely update the wiki to spell this out more clearly (as part of issue #349 https://github.com/buzsakilab/buzcode/issues/349)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/369?email_source=notifications&email_token=AGDT4EH4M2DSWYYEAH3FRM3QULMULA5CNFSM4JOX62QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELNMLQ#issuecomment-555144750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDT4EAAP2CZKKHX2N7MCJTQULMULANCNFSM4JOX62QA .

dlevenstein commented 4 years ago

No worries at all (: this is fine - everything is in dev where it belongs :p

brendonw1 commented 4 years ago

Git... :)

On Mon, Nov 18, 2019 at 1:36 PM Dan Levenstein notifications@github.com wrote:

No worries at all (: this is fine - everything is in dev where it belongs :p

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/369?email_source=notifications&email_token=AA26WTNKXXIDUFKRJEPWW2DQULODJA5CNFSM4JOX62QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELOV5I#issuecomment-555150069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26WTIFCIFXFHVKBMDGKVLQULODJANCNFSM4JOX62QA .

brendonw1 commented 4 years ago

I tried looking at this. I don't understand what this code is for, although I bet it's cool. Can you add comments at the top about what it is trying to accomplish?

Same with bz_getSpikesRank.m

On Mon, Nov 18, 2019 at 1:39 PM Brendon Watson brendon.watson@gmail.com wrote:

Git... :)

On Mon, Nov 18, 2019 at 1:36 PM Dan Levenstein notifications@github.com wrote:

No worries at all (: this is fine - everything is in dev where it belongs :p

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/369?email_source=notifications&email_token=AA26WTNKXXIDUFKRJEPWW2DQULODJA5CNFSM4JOX62QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELOV5I#issuecomment-555150069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26WTIFCIFXFHVKBMDGKVLQULODJANCNFSM4JOX62QA .

acnavasolive commented 4 years ago

Yeah, sure! I will comment them more extensively. Basically they are a tandem of functions to perform a rank order analysis (from Stark et al 2015 PNAS) to find significant sequences in your data (ripples, theta, etc..). There are more details that I will try to clarify also in the documentation. Thanks for your suggestion! -------- Mensaje original --------De: Brendon Watson notifications@github.comFecha: lun., 18 nov. 2019 20:32Para: buzsakilab/buzcode buzcode@noreply.github.comCc: Andrea Navas-Olive acnavasolive@gmail.com, Author author@noreply.github.comAsunto: Re: [buzsakilab/buzcode] bz_RankOrder (#369)I tried looking at this. I don't understand what this code is for,

although I bet it's cool. Can you add comments at the top about what it is

trying to accomplish?

Same with

bz_getSpikesRank.m

On Mon, Nov 18, 2019 at 1:39 PM Brendon Watson brendon.watson@gmail.com

wrote:

Git... :)

On Mon, Nov 18, 2019 at 1:36 PM Dan Levenstein notifications@github.com

wrote:

No worries at all (: this is fine - everything is in dev where it belongs

:p

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub

https://github.com/buzsakilab/buzcode/pull/369?email_source=notifications&email_token=AA26WTNKXXIDUFKRJEPWW2DQULODJA5CNFSM4JOX62QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELOV5I#issuecomment-555150069,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AA26WTIFCIFXFHVKBMDGKVLQULODJANCNFSM4JOX62QA

.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.