search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 126 forks source link

adding permutation tests to bz_CFCPhaseAmp #372

Closed eliezyer closed 4 years ago

eliezyer commented 4 years ago

As discussed with @AntonioFR8, I added a permutation test to the CFC function.

@AntonioFR8, it would be great if you tested. I could only do some quick plots and looked fine.

eliezyer commented 4 years ago

related to issue #292

AntonioFR8 commented 4 years ago

Ok, thanks, I will test it

On Fri, Nov 22, 2019 at 4:24 PM Eliezyer notifications@github.com wrote:

As discussed with @AntonioFR8 https://github.com/AntonioFR8, I added a permutation test to the CFC function.

@AntonioFR8 https://github.com/AntonioFR8, it would be great if you tested. I could only do some quick plots and looked fine.

You can view, comment on, or merge this pull request online at:

https://github.com/buzsakilab/buzcode/pull/372 Commit Summary

  • fixing conflicts
  • Merge pull request #5 from buzsakilab/dev
  • Merge branch 'dev_EFO' of https://github.com/eliezyer/buzcode into dev_EFO
  • adding permutation test on CFC function

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/372?email_source=notifications&email_token=ADHSQQYMPU573EUJNNXVZDDQVBE2FA5CNFSM4JQWFI6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3P2IFA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHSQQ6HQRR64CNTA56YO63QVBE2FANCNFSM4JQWFI6A .

-- Antonio Fernandez-Ruiz, PhD Sir Henry Wellcome Post-doctoral fellow Buzsaki Lab. NYU Neuroscience Institute New York University, Langone Medical Center East River Science Park, 450 East 29th Street, 9th Floor New York, NY 10016

eliezyer commented 4 years ago

Forgot to mention, but in this pull request I also sent an update on ConvertPhyKilo2Neurosuite to accommodate conversions from kilosort2/phy2 to neurosuite. There are no needs for extra plugins using phy2

AntonioFR8 commented 4 years ago

Thanks Eli. Are you guys happy with Kilo2/ phy2? Are they better than the previous version?

On Nov 24, 2019, at 1:12 PM, Eliezyer notifications@github.com wrote:

Forgot to mention, but in this pull request I also sent an update on ConvertPhyKilo2Neurosuite to accommodate conversions from kilosort2/phy2 to neurosuite. There are no needs for extra plugins using phy2

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/372?email_source=notifications&email_token=ADHSQQ4MSDXEQ3KTVA5H5LLQVK7ZXA5CNFSM4JQWFI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFARJTI#issuecomment-557913293, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHSQQYF2A73VUBQ2LXJCXTQVK7ZXANCNFSM4JQWFI6A.