search

buzsakilab / buzcode

Code for internal lab sharing - polishing has started but is by no means complete
http://www.buzsakilab.com/
GNU General Public License v3.0
119 stars 128 forks source link

updating bz_GetSpikes.m to load ks2 files #402

Closed eliezyer closed 3 years ago

eliezyer commented 3 years ago

related to #401

brendonw1 commented 3 years ago

@valegarman @eliezyer I think this looks fine, but I'm starting to become an "old PI" and haven't been doing so much of detailed coding lately (more grants). So I'd like it if Manuel could look too?

brendonw1 commented 3 years ago

Maybe @AntonioFR8 can look too?

eliezyer commented 3 years ago

Did a small update on the new code to use the field spikeGroups instead of SpkGrps from sessionInfo structure, I see that's preferable based on the rest of the code

valegarman commented 3 years ago

Looks very good to me. Thanks!!

eliezyer commented 3 years ago

Thanks both of you for reviewing! I think you meant to merge instead of close? I merged now but revert that if needed

brendonw1 commented 3 years ago

Thanks Eli

On Thu, Nov 19, 2020 at 10:38 AM Eliezyer notifications@github.com wrote:

Thanks both of you for reviewing! I think you meant to merge instead of close? I merged now but revert that if needed

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/buzsakilab/buzcode/pull/402#issuecomment-730456847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA26WTPTBAGZQLIZANEQWULSQU3WBANCNFSM4TXJRC7A .