search

buzz / mediainfo.js

Extract media file metadata in the browser using WebAssembly.
https://mediainfo.js.org
BSD 2-Clause "Simplified" License
712 stars 108 forks source link

CDN not working #142

Closed TheMadog24 closed 1 year ago

TheMadog24 commented 1 year ago

Checklist

Bug Description

When using the CDN, it no longer works, it seems to not be able to find MediaInfoModule.wasm which is a dependency.

Steps to Reproduce

I will be honest, I am not an expert, and I do not really know too much, but I did have this working for several months in HTML/JS. it stopped working all of a sudden, so I updated the CDN in my script in the <head> section of my page, and still no luck.

Expected Behavior

That it would work again.

Actual Behavior

It does not work. it seems to not be able to find MediaInfoModule.wasm Image below of the error. I really do not understand most of it, I am still learning, and a lot of this is new to me.

Environment

HTML/CSS/Javascript

Additional Information

image

buzz commented 1 year ago

Did you see this and this?

As you decided not to share any code it is hard to tell for sure, but my guess is, you're loading the CDN version from https://unpkg.com/mediainfo.js or something alike and didn't use the locateFile option?

It works out-of-the-box when using https://unpkg.com/mediainfo.js/dist/umd/index.min.js like in the example.

buzz commented 1 year ago

I fixed the WASM loading behavior, so loading the script from https://unpkg.com/mediainfo.js also works without the need to fiddle with locateFile. Also, I aligned the CDN example to the README.md.

TheMadog24 commented 1 year ago

As you decided not to share any code it is hard to tell for sure

I apologize, I am still a bit new to this, and wasn't sure what to share, or how to use locateFile. I just copied what the CodePen, and figured out the rest on my own.

<script type="text/javascript" src="https://unpkg.com/mediainfo.js"></script>

    MediaInfo({
        format: 'JSON',
        locateFile: (path, prefix) => prefix + path, // Make sure WASM file is loaded from CDN location
    },
        (mediainfo) => {
    fileinput.addEventListener('change', () => onChangeFile(mediainfo))
    })

It still does not seem to work, I get the same error. I apologize for the inconvenience.

image

buzz commented 1 year ago

I just copied what the CodePen, and figured out the rest on my own.

I'm not sure where the code comes from that you pasted. Why don't you just use the example code, e.g. the CodePen or the Browser UMD example. There's no need to fiddle with locateFile if you don't have to.

Apart from that Stack Overflow is a wonderful place to ask questions like this.

TheMadog24 commented 1 year ago

I'm not sure where the code comes from that you pasted.

It was from the CodePen link on this project, but it was from over 6 months ago. Everything was working until about a month ago. I couldn't figure it out on my own, so I came here asking/thinking it was a bug, since I didn't change anything.

Why don't you just use the example code, e.g. the CodePen or the Browser UMD example.

I will try this, thank you so much.

EDIT: Thank you very much, I made the changes you linked, and it now works again.