search

buzzer13 / esphome-components

Custom ESPHome component repository
GNU General Public License v3.0
4 stars 9 forks source link

Fix compilation post Esphome 2023.6 #2

Closed FatBeard closed 1 year ago

FatBeard commented 1 year ago

Hi, this fixes the breaking change for custom components using ESPTime in Esphome 2023.6

See https://github.com/esphome/esphome/pull/4926

Great custom component btw, i just got my clock set up after it lying on my desk for months. You may want to squash the commit messages as some of them are non sensical

FatBeard commented 1 year ago

FYI, I'm going to create a pr for the ds1302 component too.

buzzer13 commented 1 year ago

Hi, thanks for your fix! I've merged #1 that resolves the same issue as this PR, but I've also cleaned up includes a bit based on your changes (after seeing that you didn't include esphome/core/time.h explicitly).

FatBeard commented 1 year ago

That's fine. I saw the other pr after I raised mine. Thanks again.