buzzfeed / Sketch-Toolbox

DEPRECATED: A plugin manager for Sketch.app
MIT License
2.12k stars 204 forks source link

Tool installs every single plugin under the sun on first run #1

Closed bomberstudios closed 10 years ago

bomberstudios commented 10 years ago

Definitely not a good idea

bomberstudios commented 10 years ago

This morning I reported an issue where Sketch Toolbox would overwrite existing folders in the Plugin folder, potentially causing data loss if you had uncommitted changes on a local working copy of a plugin.

I can't replicate the issue now, and so I removed the comment. But I've definitely experienced data loss in one of my repos, and thought I'd let you know just in case you can add some extra security measures : )

shahruz commented 10 years ago

Yikes, just realized what was happening. A very naive bug on my part, the app was assuming that each plugin was already installed and therefore auto-updating. I've pushed out a fix.

Very sorry about this!!! Thanks for the heads up.

bomberstudios commented 10 years ago

Thanks! : )