buzzfeed / Sketch-Toolbox

DEPRECATED: A plugin manager for Sketch.app
MIT License
2.12k stars 204 forks source link

Sketch Versions #20

Closed ramijames closed 10 years ago

ramijames commented 10 years ago

I've compiled the app and it seems to successfully download and install plugins.

I am not able to see them or access them via Sketch (2.4.3).

Is this only working for Sketch 3?

shahruz commented 10 years ago

I've only tested on Sketch 3 and Sketch 3 Beta so far. Adding in support for Sketch 2 should be possible, but this ties into the issues being discussed in #15, where some plugins may only have specific capabilities.

I'll add in support for Sketch 2 later today (it should be trivial), and I think we can fix the catalog issue afterwards. I don't think there are too many plugins which will cause trouble one way or another.

ramijames commented 10 years ago

Ya, I guess that means that plugin authors need to let the toolbox know which version of sketch they target. Hmm.

shahruz commented 10 years ago

@ramijames Yep. That's part of the plans. I just pushed up a fix. The Toolbox will detect which version(s) of Sketch you have installed (Sketch 3, Sketch 3 Beta, Sketch 2) and will install to all you have. Can you test to see if it's working for you?

ramijames commented 10 years ago

I've downloaded and compiled again. Doesn't seem to indicate anywhere whether it has detected the version or not. I've tried installing a bunch of plugins but they still don't show up in Sketch 2.

"Copy Fill Color" indicates its a Sketch 2 plugin, but it isn't showing up anywhere, even when I search for it in spotlight.

I may be doing something incorrectly though.

bomberstudios commented 10 years ago

Please note that you're missing ~/Library/Application Support/sketch/Plugins/, which is the Plugin path for non-sandboxed versions of Sketch 2 (either the betas, or versions purchased from our own store)

ramijames commented 10 years ago

Yes, I'm running a sandboxed version of Sketch 2 (app store).

ramijames commented 10 years ago

Yup, the plugins directory in ~/Library/Application Support/sketch/plugins/ is empty for me. screen shot 2014-05-28 at 8 40 26 pm

shahruz commented 10 years ago

Ah interesting. I'll add that path (and a way to manage them better). So the list of available paths will be:

Sketch 3 App Store: ~/Library/Containers/com.bohemiancoding.sketch3/Data/Library/Application Support/com.bohemiancoding.sketch3/Plugins/ Sketch 3 Beta: ~/Library/Application Support/com.bohemiancoding.sketch3/Plugins/

Sketch 2 App Store: ~/Library/Containers/com.bohemiancoding.sketch/Data/Library/Application Support/sketch/Plugins/ Sketch 2: ~/Library/Application Support/sketch/Plugins/

Does this sound right, @bomberstudios ?

ramijames commented 10 years ago

Yes, that seems to be the correct path for me. screen shot 2014-05-28 at 8 42 49 pm

bomberstudios commented 10 years ago

@shahruz that sounds about right, yes : )

shahruz commented 10 years ago

Thanks!

Ok, just pushed up what I believe to be a fix. @ramijames you may need to uninstall / reinstall the plugin(s) you're testing.

ramijames commented 10 years ago

Confirmed fixed for me.

shahruz commented 10 years ago

Rad. Closing out the issue. Thanks for your help!

ramijames commented 10 years ago

:)