Refactor cache trimming

buzzfeed / mattress

iOS Offline Caching for Web Content

MIT License

520 stars 45 forks source link

Refactor cache trimming #18

Closed lordkev closed 9 years ago

lordkev commented 9 years ago

https://buzzfeed.atlassian.net/browse/IOSARCH-84

@Cform @dmauro

Cform commented 9 years ago

Small suggestion. LGTM

dmauro commented 9 years ago

LGTM. I'm fine with the two do blocks for better error messages (unless we know what error types we're looking for and could use those to have two different catch scopes).

lordkev commented 9 years ago

Combining sounds good to me. I think the chances of getting attributes succeeding but deleting failing is likely extremely small, so may as well handle them both in one block.