buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services

MIT License

3.1k stars 186 forks source link

docs: update quickstart guide #263

Closed mccutchen closed 5 years ago

mccutchen commented 5 years ago

Problem

In the course of working on https://github.com/buzzfeed/sso/pull/262, I found a couple of small issues with the quickstart guide: the quickstart-specific suggested OAuth callback URLs in the google & okta provider setup docs were incomplete.

Solution

FIrst, fix the suggested URLs. I also made a few more invasive/opinionated wording/structure changes to the quickstart guide itself, if these changes do not seem like an improvement to y'all I will revert them!

Jusshersmith commented 5 years ago

Thanks @mccutchen -- couple small comments, but this looks great!

codecov[bot] commented 5 years ago

Codecov Report

Merging #263 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   62.14%   62.14%           
=======================================
  Files          53       53           
  Lines        4169     4169           
=======================================
  Hits         2591     2591           
  Misses       1391     1391           
  Partials      187      187